Histogram metric of HTTP request duration ignroes Put requests #280

New issue

Closed

opened 2023-12-11 11:19:59 +00:00 by alexvanin · 0 comments

alexvanin commented

2023-12-11 11:19:59 +00:00

Owner

Found by @a.bogatyrev

Expected Behavior

frostfs_s3_gw_statistic_requests_seconds_bucket metric provide both Put and Get api labels.

Current Behavior

Metric calculates only Get api labels.

Possible Solution

Update HTTP Verb condition check in middleware.

if r.Method == http.MethodGet {
	// Increment the prometheus http request response histogram with appropriate label
	appMetrics.Statistic().RequestDurationsUpdate(reqInfo.API, durationSecs)
}

Steps to Reproduce (for bugs)

Create bucket
Upload an object
Get an object
Read metrics

Regression

No. It was introduced back in 2020 during initial development.

Your Environment

frostfs-aio v1.3.0

Found by @a.bogatyrev ## Expected Behavior `frostfs_s3_gw_statistic_requests_seconds_bucket` metric provide both Put and Get `api` labels. ## Current Behavior Metric calculates only Get `api` labels. ## Possible Solution Update HTTP Verb condition check in middleware. ```go if r.Method == http.MethodGet { // Increment the prometheus http request response histogram with appropriate label appMetrics.Statistic().RequestDurationsUpdate(reqInfo.API, durationSecs) } ``` ## Steps to Reproduce (for bugs) 1. Create bucket 2. Upload an object 3. Get an object 4. Read metrics ## Regression No. It was introduced back in 2020 during initial development. ## Your Environment frostfs-aio v1.3.0