[#280] Add put requests to duration metric #285

mbiryukova · 2023-12-21T08:31:35Z

mbiryukova commented

2023-12-21 08:31:35 +00:00

Closes #280

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Closes #280 Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>

mbiryukova self-assigned this 2023-12-21 08:31:35 +00:00

mbiryukova requested review from storage-services-committers 2023-12-21 08:52:55 +00:00

mbiryukova requested review from storage-services-developers 2023-12-21 08:52:55 +00:00

dkirillov reviewed 2023-12-21 09:05:52 +00:00

api/middleware/metrics.go Outdated

													
				@ -96,3 +96,3 @@

						}

						if r.Method == http.MethodGet {

						if r.Method == http.MethodGet || r.Method == http.MethodPut {

dkirillov commented

2023-12-21 09:05:52 +00:00

Maybe we can drop condition at all?
cc @alexvanin

Maybe we can drop condition at all? cc @alexvanin

alexvanin commented

2023-12-22 13:27:25 +00:00

Let's do it. Don't see much value in it.

dkirillov marked this conversation as resolved

mbiryukova force-pushed bugfix/put_reqs_to_duration_metric from 27caf0f328 to 08019f1574

2023-12-22 13:35:39 +00:00

Compare

dkirillov approved these changes 2023-12-22 13:51:18 +00:00

r.loginov approved these changes 2023-12-22 14:15:56 +00:00

alexvanin merged commit 08019f1574 into master

2023-12-25 08:56:33 +00:00

alexvanin deleted branch bugfix/put_reqs_to_duration_metric

2023-12-25 08:56:34 +00:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#285