TrueCloudLab
/
frostfs-s3-gw
16
2
Fork 14
Code Issues 19 Pull Requests 3 Actions Packages Releases 6 Activity

Use 'c' prefix for bucket policies instead of 'n' #360

Merged
alexvanin merged 2 commits from alexvanin/frostfs-s3-gw:fix/8574 into support/v0.29 2024-04-10 14:56:06 +00:00
Conversation 0 Commits 2 Files Changed 8
alexvanin commented 2024-04-10 12:54:34 +00:00
Owner

With 'c' prefix, acl chains become shorter, thus gateway
receives shorter results and avoids sessions to neo-go.

There is still issue with many IAM rules.

With 'c' prefix, acl chains become shorter, thus gateway receives shorter results and avoids sessions to neo-go. There is still issue with many IAM rules.
alexvanin added 1 commit 2024-04-10 12:54:36 +00:00
/ Vulncheck (pull_request) Failing after 2m15s Details
/ Lint (pull_request) Failing after 2m0s Details
/ Tests (1.20) (pull_request) Failing after 2m30s Details
/ Tests (1.21) (pull_request) Failing after 2m24s Details
/ DCO (pull_request) Failing after 2m4s Details
/ Builds (1.20) (pull_request) Successful in 2m34s Details
/ Builds (1.21) (pull_request) Successful in 2m28s Details
335cfd3a3b [#xxx] Use 'c' prefix for bucket policies instead of 'n' 
With 'c' prefix, acl chains become shorter, thus gateway
receives shorter results and avoids sessions to neo-go.

There is still issue with many IAM rules.

Signed-off-by: Alex Vanin <a.vanin@yadro.com>
dkirillov reviewed 2024-04-10 13:07:28 +00:00
api/middleware/policy.go Outdated
@ -76,1 +81,3 @@
st = chain.NoRuleFound
st := chain.NoRuleFound
for _, target := range targets {
status, found, err := cfg.Storage.IsAllowed(chain.S3, target, req)
dkirillov commented 2024-04-10 13:07:28 +00:00
Collaborator

Why don't we use just one RequestTarget?

if bktInfo !=nil {
	cnrTarget:=engine.ContainerTarget(bktInfo.CID.EncodeToString())
	target.Container = &cnrTarget
}
Why don't we use just one `RequestTarget`? ```golang if bktInfo !=nil { cnrTarget:=engine.ContainerTarget(bktInfo.CID.EncodeToString()) target.Container = &cnrTarget } ```
alexvanin commented 2024-04-10 13:16:27 +00:00
Poster
Owner

Missed that, thanks!

Missed that, thanks!
alexvanin added 1 commit 2024-04-10 13:29:27 +00:00
/ DCO (pull_request) Failing after 1m37s Details
/ Builds (1.20) (pull_request) Successful in 2m34s Details
/ Builds (1.21) (pull_request) Successful in 1m53s Details
/ Vulncheck (pull_request) Failing after 2m14s Details
/ Lint (pull_request) Failing after 2m31s Details
/ Tests (1.20) (pull_request) Failing after 2m37s Details
/ Tests (1.21) (pull_request) Failing after 2m22s Details
3863c0689c [#xxx] Reuse single target during policy check 
Policy engine library is able to manage multiple
targets and resolve different status results.

Signed-off-by: Alex Vanin <a.vanin@yadro.com>
alexvanin force-pushed fix/8574 from 3863c0689c to 802f3f57f9 2024-04-10 14:06:21 +00:00 Compare
alexvanin requested review from storage-services-committers 2024-04-10 14:06:31 +00:00
alexvanin requested review from storage-services-developers 2024-04-10 14:06:31 +00:00
alexvanin changed title from WIP: Use 'c' prefix for bucket policies instead of 'n' to Use 'c' prefix for bucket policies instead of 'n' 2024-04-10 14:07:01 +00:00
alexvanin force-pushed fix/8574 from 802f3f57f9 to 65a8e2dadc 2024-04-10 14:40:34 +00:00 Compare
dkirillov approved these changes 2024-04-10 14:52:12 +00:00
alexvanin merged commit 65a8e2dadc into support/v0.29 2024-04-10 14:56:06 +00:00
alexvanin deleted branch fix/8574 2024-04-10 14:56:06 +00:00
alexvanin added this to the v0.29.0 milestone 2024-05-27 10:06:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.29.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#360
There is no content yet.
Delete Branch "alexvanin/frostfs-s3-gw:fix/8574"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?