TrueCloudLab/frostfs-s3-gw
14
2
Fork 17
Code Issues 22 Pull requests 6 Projects Releases 15 Packages Activity Actions

Use 'c' prefix for bucket policies instead of 'n' #360

Merged
alexvanin merged 1 commit from alexvanin/frostfs-s3-gw:fix/8574 into support/v0.29 2024-09-04 19:51:13 +00:00
Conversation 0 Commits 1 Files changed 1 +10 -16
alexvanin commented 2024-04-10 12:54:34 +00:00
Owner
Copy link

With 'c' prefix, acl chains become shorter, thus gateway
receives shorter results and avoids sessions to neo-go.

There is still issue with many IAM rules.

With 'c' prefix, acl chains become shorter, thus gateway receives shorter results and avoids sessions to neo-go. There is still issue with many IAM rules.
dkirillov reviewed 2024-04-10 13:07:28 +00:00
api/middleware/policy.go Outdated
@ -76,1 +81,3 @@
st = chain.NoRuleFound
st := chain.NoRuleFound
for _, target := range targets {
status, found, err := cfg.Storage.IsAllowed(chain.S3, target, req)
dkirillov commented 2024-04-10 13:07:28 +00:00
Member
Copy link

Why don't we use just one RequestTarget?

if bktInfo !=nil {
	cnrTarget:=engine.ContainerTarget(bktInfo.CID.EncodeToString())
	target.Container = &cnrTarget
}
Why don't we use just one `RequestTarget`? ```golang if bktInfo !=nil { cnrTarget:=engine.ContainerTarget(bktInfo.CID.EncodeToString()) target.Container = &cnrTarget } ```
alexvanin commented 2024-04-10 13:16:27 +00:00
Author
Owner
Copy link

Missed that, thanks!

Missed that, thanks!
alexvanin force-pushed fix/8574 from 3863c0689c to 802f3f57f9 2024-04-10 14:06:21 +00:00 Compare
alexvanin requested review from storage-services-committers 2024-04-10 14:06:31 +00:00
alexvanin requested review from storage-services-developers 2024-04-10 14:06:31 +00:00
alexvanin changed title from WIP: Use 'c' prefix for bucket policies instead of 'n' to Use 'c' prefix for bucket policies instead of 'n' 2024-04-10 14:07:01 +00:00
alexvanin force-pushed fix/8574 from 802f3f57f9 to 65a8e2dadc 2024-04-10 14:40:34 +00:00 Compare
dkirillov approved these changes 2024-04-10 14:52:12 +00:00
alexvanin merged commit 65a8e2dadc into support/v0.29 2024-04-10 14:56:06 +00:00
alexvanin deleted branch fix/8574 2024-04-10 14:56:06 +00:00
alexvanin added this to the v0.29.0 milestone 2024-05-27 10:06:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.29.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#360
No description provided.
Delete branch "alexvanin/frostfs-s3-gw:fix/8574"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?