TrueCloudLab/frostfs-s3-gw
15
2
Fork 17
Code Issues 19 Pull requests 6 Projects Releases 13 Packages Activity Actions

[#414] authmate: Support setting policy chain #414

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:poc/new_authmate into master 2024-07-08 12:14:43 +00:00
Conversation 0 Commits 1 Files changed 12 +284 -93
dkirillov commented 2024-07-02 08:54:28 +00:00
Member
Copy link

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2024-07-02 08:54:28 +00:00
dkirillov changed title from WIP: [#XX] authmate: Support setting policy chain to WIP: [#414] authmate: Support setting policy chain 2024-07-02 08:55:40 +00:00
dkirillov force-pushed poc/new_authmate from dc3105bd44 to e02958dcab 2024-07-02 09:00:55 +00:00 Compare
dkirillov changed title from WIP: [#414] authmate: Support setting policy chain to [#414] authmate: Support setting policy chain 2024-07-02 09:01:53 +00:00
dkirillov requested review from storage-services-committers 2024-07-02 09:03:08 +00:00
alexvanin approved these changes 2024-07-08 10:50:37 +00:00
alexvanin left a comment
Owner
Copy link

Looks great, tested it with frostfs-aio. Consider some naming changes in this PR.

Looks great, tested it with frostfs-aio. Consider some naming changes in this PR.
cmd/s3-authmate/modules/register-user.go Outdated
@ -0,0 +42,4 @@
const walletContractPassphraseCfg = "wallet.contract.passphrase"
func initRegisterUserCmd() {
registerUserCmd.Flags().String(walletFlag, "", "Path to the wallet that will be owner of the credentials")
alexvanin commented 2024-07-08 10:01:52 +00:00
Owner
Copy link

More like Path to the wallet with account of the user that will be registered in FrostFS ID contract?

More like `Path to the wallet with account of the user that will be registered in FrostFS ID contract?`
alexvanin marked this conversation as resolved
cmd/s3-authmate/modules/register-user.go Outdated
@ -0,0 +43,4 @@
func initRegisterUserCmd() {
registerUserCmd.Flags().String(walletFlag, "", "Path to the wallet that will be owner of the credentials")
registerUserCmd.Flags().String(addressFlag, "", "Address of the wallet account")
alexvanin commented 2024-07-08 10:04:35 +00:00
Owner
Copy link

Maybe Address of the user wallet that will be registered in FrostFS ID contract

Maybe `Address of the user wallet that will be registered in FrostFS ID contract`
alexvanin marked this conversation as resolved
cmd/s3-authmate/modules/register-user.go Outdated
@ -0,0 +47,4 @@
registerUserCmd.Flags().String(frostfsIDContractFlag, "frostfsid.frostfs", "FrostfsID contract hash (LE) or name in NNS to register public key in contract")
registerUserCmd.Flags().String(proxyContractFlag, "proxy.frostfs", "Proxy contract hash (LE) or name in NNS to use when interact with frostfsid contract")
registerUserCmd.Flags().String(namespaceFlag, "", "Namespace to register public key in frostfsid contract and add policy chains")
registerUserCmd.Flags().String(frostfsIDNameFlag, "", "Subject name to set for public key in frostfsid contract")
alexvanin commented 2024-07-08 10:05:55 +00:00
Owner
Copy link

Can we just call it a --name or --username?

We also don't use subject term much here, so I would stick with user or use subject everywhere else.

Can we just call it a `--name` or `--username`? We also don't use `subject` term much here, so I would stick with `user` or use `subject` everywhere else.
alexvanin marked this conversation as resolved
dkirillov force-pushed poc/new_authmate from e02958dcab to 70eedfc077 2024-07-08 11:13:33 +00:00 Compare
alexvanin merged commit 70eedfc077 into master 2024-07-08 12:14:43 +00:00
alexvanin deleted branch poc/new_authmate 2024-07-08 12:14:47 +00:00
alexvanin added this to the v0.30.0 milestone 2024-07-16 11:24:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.30.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#414
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:poc/new_authmate"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?