TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 6 Projects Releases 18 Packages Activity Actions

[#427] layer: Split FrostFS ReadObject to separate methods #427

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:feature/frostfs_get_simplify into master 2024-07-24 12:11:19 +00:00
Conversation 0 Commits 1 Files changed 13 +198 -139
dkirillov commented 2024-07-15 12:54:05 +00:00
Member
Copy link

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2024-07-15 12:54:06 +00:00
dkirillov added 1 commit 2024-07-15 12:54:39 +00:00
[#XX] layer: Split FrostFS ReadObject to separate methods
Some checks failed
/ DCO (pull_request) Failing after 3m19s
Details
/ Vulncheck (pull_request) Successful in 3m47s
Details
/ Builds (1.20) (pull_request) Successful in 5m6s
Details
/ Builds (1.21) (pull_request) Successful in 4m41s
Details
/ Lint (pull_request) Successful in 7m16s
Details
/ Tests (1.20) (pull_request) Successful in 4m52s
Details
/ Tests (1.21) (pull_request) Successful in 4m34s
Details
48682ef68f 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov force-pushed feature/frostfs_get_simplify from 48682ef68f to 44f8188b52 2024-07-15 12:56:46 +00:00 Compare
dkirillov force-pushed feature/frostfs_get_simplify from 44f8188b52 to 2e0c48a37a 2024-07-15 13:18:32 +00:00 Compare
dkirillov force-pushed feature/frostfs_get_simplify from 2e0c48a37a to 6dbd387f5d 2024-07-15 14:11:12 +00:00 Compare
dkirillov changed title from WIP: [#XX] layer: Split FrostFS ReadObject to separate methods to WIP: [#427] layer: Split FrostFS ReadObject to separate methods 2024-07-15 14:14:49 +00:00
dkirillov changed title from WIP: [#427] layer: Split FrostFS ReadObject to separate methods to [#427] layer: Split FrostFS ReadObject to separate methods 2024-07-15 14:20:50 +00:00
dkirillov requested review from storage-services-committers 2024-07-15 14:21:05 +00:00
dkirillov requested review from storage-services-developers 2024-07-15 14:21:08 +00:00
dkirillov force-pushed feature/frostfs_get_simplify from 6dbd387f5d to 8d8537296c 2024-07-22 06:39:03 +00:00 Compare
alexvanin approved these changes 2024-07-23 12:08:24 +00:00
api/layer/object.go Outdated
@ -178,2 +164,4 @@
}
// objectGet returns an object with payload in the object.
func (n *Layer) objectGet(ctx context.Context, bktInfo *data.BucketInfo, objID oid.ID) (*Object, error) {
alexvanin commented 2024-07-23 12:06:30 +00:00
Owner
Copy link

Can we keep it on the same place at 157 line before MimeByFilePath function?

Can we keep it on the same place at 157 line before `MimeByFilePath` function?
👍 1
dkirillov force-pushed feature/frostfs_get_simplify from 8d8537296c to 6cb0026007 2024-07-23 13:56:16 +00:00 Compare
alexvanin added this to the v0.31.0 milestone 2024-07-24 12:11:16 +00:00
alexvanin merged commit 6cb0026007 into master 2024-07-24 12:11:19 +00:00
alexvanin deleted branch feature/frostfs_get_simplify 2024-07-24 12:11:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.31.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#427
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:feature/frostfs_get_simplify"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?