TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 6 Projects Releases 18 Packages Activity Actions

[#448] multipart: Support removing duplicated parts #448

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:bugfix/split_tree_duplicated_parts into master 2024-09-03 13:20:39 +00:00
Conversation 0 Commits 1 Files changed 9 +336 -68
dkirillov commented 2024-08-01 12:15:06 +00:00
Member
Copy link

Previously after tree split we can have duplicated parts
(several objects and tree node referred to the same part number).
Some of them couldn't be deleted after abort or compete action.

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Previously after tree split we can have duplicated parts (several objects and tree node referred to the same part number). Some of them couldn't be deleted after abort or compete action. Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2024-08-01 12:15:06 +00:00
dkirillov added 1 commit 2024-08-01 12:15:13 +00:00
[#XX] multipart: Support removing duplicated parts
Some checks failed
/ DCO (pull_request) Failing after 2m1s
Details
/ Vulncheck (pull_request) Successful in 2m52s
Details
/ Builds (1.21) (pull_request) Successful in 1m55s
Details
/ Builds (1.22) (pull_request) Successful in 3m9s
Details
/ Lint (pull_request) Successful in 3m37s
Details
/ Tests (1.21) (pull_request) Successful in 3m4s
Details
/ Tests (1.22) (pull_request) Successful in 3m3s
Details
5d0eef5a56 
Previously after tree split we can have duplicated parts
(several objects and tree node referred to the same part number).
Some of them couldn't be deleted after abort or compete action.

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov force-pushed bugfix/split_tree_duplicated_parts from 5d0eef5a56 to 5bf79a2e63 2024-08-01 12:15:33 +00:00 Compare
dkirillov changed title from [#XX] multipart: Support removing duplicated parts to [#448] multipart: Support removing duplicated parts 2024-08-01 12:15:35 +00:00
dkirillov requested review from storage-services-developers 2024-08-01 12:16:11 +00:00
dkirillov requested review from storage-services-committers 2024-08-01 12:16:15 +00:00
dkirillov force-pushed bugfix/split_tree_duplicated_parts from 5bf79a2e63 to e77cae5bd7 2024-08-26 09:36:57 +00:00 Compare
alexvanin approved these changes 2024-09-03 12:41:49 +00:00
alexvanin left a comment
Owner
Copy link

Actually, this looks quite straightforward and clear. Let's merge it after rebase.

Actually, this looks quite straightforward and clear. Let's merge it after rebase.
api/data/tree.go Outdated
@ -128,1 +128,4 @@
type PartInfoExtended struct {
PartInfo
Timestamp uint64
alexvanin commented 2024-09-03 12:40:02 +00:00
Owner
Copy link

Let's write some comment about timestamp or whole PartInfoExtended structure, why we need that at all. If I understand correctly:

Timestamp is used to find latest version of part info in case of tree split when there are multiple nodes for the same part.
Let's write some comment about timestamp or whole `PartInfoExtended` structure, why we need that at all. If I understand correctly: ``` Timestamp is used to find latest version of part info in case of tree split when there are multiple nodes for the same part. ```
👍 1
alexvanin marked this conversation as resolved
dkirillov force-pushed bugfix/split_tree_duplicated_parts from e77cae5bd7 to f11aad634b 2024-09-03 12:59:40 +00:00 Compare
alexvanin approved these changes 2024-09-03 13:20:32 +00:00
alexvanin merged commit 056f168d77 into master 2024-09-03 13:20:39 +00:00
alexvanin deleted branch bugfix/split_tree_duplicated_parts 2024-09-03 13:20:43 +00:00
alexvanin added this to the v0.31.0 milestone 2024-09-03 13:20:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.31.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#448
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:bugfix/split_tree_duplicated_parts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?