TrueCloudLab/frostfs-s3-gw
18
3
Fork 20
Code Issues 29 Pull requests 8 Projects Releases 23 Packages Activity Actions

PostObject doesn't work #456

New issue
Closed
opened 2024-08-09 14:10:02 +00:00 by dkirillov · 0 comments
dkirillov commented 2024-08-09 14:10:02 +00:00
Member
Copy link

Expected Behavior

Post object works as expected https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-UsingHTTPPOST.html

Current Behavior

We get panic:

 panic: runtime error: invalid memory address or nil pointer dereference
 
 -> git.frostfs.info/TrueCloudLab/frostfs-s3-gw/api.NewRouter.Auth.func5.1
 ->   /home/denis/github/tcl/neofs-s3-gw/api/middleware/auth.go:75

    net/http.HandlerFunc.ServeHTTP
      /home/denis/go/go1.21.6/src/net/http/server.go:2136
    git.frostfs.info/TrueCloudLab/frostfs-s3-gw/api.NewRouter.LogSuccessResponse.func4.1
      /home/denis/github/tcl/neofs-s3-gw/api/middleware/response.go:304
    net/http.HandlerFunc.ServeHTTP
      /home/denis/go/go1.21.6/src/net/http/server.go:2136
    git.frostfs.info/TrueCloudLab/frostfs-s3-gw/api/middleware.stats.func1
      /home/denis/github/tcl/neofs-s3-gw/api/middleware/metrics.go:75
    net/http.HandlerFunc.ServeHTTP
      /home/denis/go/go1.21.6/src/net/http/server.go:2136
    git.frostfs.info/TrueCloudLab/frostfs-s3-gw/api.NewRouter.Tracing.func2.1
      /home/denis/github/tcl/neofs-s3-gw/api/middleware/tracing.go:23
    net/http.HandlerFunc.ServeHTTP
      /home/denis/go/go1.21.6/src/net/http/server.go:2136
    github.com/go-chi/chi/v5/middleware.Recoverer.func1
      /home/denis/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.8/middleware/recoverer.go:43
    net/http.HandlerFunc.ServeHTTP
      /home/denis/go/go1.21.6/src/net/http/server.go:2136
    github.com/go-chi/chi/v5/middleware.ThrottleWithOpts.func1.1
      /home/denis/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.8/middleware/throttle.go:100
    net/http.HandlerFunc.ServeHTTP
      /home/denis/go/go1.21.6/src/net/http/server.go:2136
    git.frostfs.info/TrueCloudLab/frostfs-s3-gw/api.NewRouter.Request.func1.1
      /home/denis/github/tcl/neofs-s3-gw/api/middleware/reqinfo.go:195
    net/http.HandlerFunc.ServeHTTP
      /home/denis/go/go1.21.6/src/net/http/server.go:2136
    github.com/go-chi/chi/v5.(*Mux).ServeHTTP
      /home/denis/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.8/mux.go:90
    net/http.serverHandler.ServeHTTP
      /home/denis/go/go1.21.6/src/net/http/server.go:2938
    net/http.(*conn).serve
      /home/denis/go/go1.21.6/src/net/http/server.go:2009
    created by net/http.(*Server).Serve in goroutine 154
      /home/denis/go/go1.21.6/src/net/http/server.go:3086

Possible Solution

diff --git a/api/auth/center.go b/api/auth/center.go
index 72fb7fea..d2c65f56 100644
--- a/api/auth/center.go
+++ b/api/auth/center.go
@@ -290,7 +290,15 @@ func (c *Center) checkFormData(r *http.Request) (*middleware.Box, error) {
 			reqSignature, signature)
 	}
 
-	return &middleware.Box{AccessBox: box, Attributes: attrs}, nil
+	return &middleware.Box{
+		AccessBox: box,
+		AuthHeaders: &middleware.AuthHeader{
+			AccessKeyID: submatches["access_key_id"],
+			Region:      region,
+			SignatureV4: signature,
+		},
+		Attributes: attrs,
+	}, nil
 }
 
 func cloneRequest(r *http.Request, authHeader *AuthHeader) *http.Request {
diff --git a/api/handler/put.go b/api/handler/put.go
index 94cc0f35..308f0a25 100644
--- a/api/handler/put.go
+++ b/api/handler/put.go
@@ -482,13 +482,22 @@ func (h *handler) PostObject(w http.ResponseWriter, r *http.Request) {
 		}
 		contentReader = file
 		size = uint64(head.Size)
-		reqInfo.ObjectName = strings.ReplaceAll(reqInfo.ObjectName, "${filename}", head.Filename)
+		if reqInfo.ObjectName == "" {
+			reqInfo.ObjectName = head.Filename
+		} else {
+			reqInfo.ObjectName = strings.ReplaceAll(reqInfo.ObjectName, "${filename}", head.Filename)
+		}
 	}
 	if !policy.CheckContentLength(size) {
 		h.logAndSendError(w, "invalid content-length", reqInfo, errors.GetAPIError(errors.ErrInvalidArgument))
 		return
 	}
 
+	if reqInfo.ObjectName == "" {
+		h.logAndSendError(w, "missing object name", reqInfo, errors.GetAPIError(errors.ErrInvalidArgument))
+		return
+	}
+
 	params := &layer.PutObjectParams{
 		BktInfo: bktInfo,
 		Object:  reqInfo.ObjectName,

Steps to Reproduce (for bugs)

Try to upload object from browser using steps from spec https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-post-example.html

Request example:

 curl -X POST http://localhost:8084/test3 \
-H 'Content-Type: multipart/form-data; boundary=ade4749fd805cf7903338195fac70a2f9a8998eae7f749b7823879dedb12' \
--data-binary ' \
--ade4749fd805cf7903338195fac70a2f9a8998eae7f749b7823879dedb12
Content-Disposition: form-data; name="Policy"

eyJleHBpcmF0aW9uIjogIjIwMjUtMTItMDFUMTI6MDA6MDAuMDAwWiIsImNvbmRpdGlvbnMiOiBbCiBbInN0YXJ0cy13aXRoIiwgIiR4LWFtei1jcmVkZW50aWFsIiwgIiJdLAogWyJzdGFydHMtd2l0aCIsICIkeC1hbXotZGF0ZSIsICIiXQpdfQ==
--ade4749fd805cf7903338195fac70a2f9a8998eae7f749b7823879dedb12
Content-Disposition: form-data; name="X-Amz-Credential"

5jizSbYu8hX345aqCKDgRWKCJYHxnzxRS8e6SUYHZ8Fw0HiRkf3KbJAWBn5mRzmiyHQ3UHADGyzVXLusn1BrmAfLn/20240809T164847Z/default/s3/aws4_request
--ade4749fd805cf7903338195fac70a2f9a8998eae7f749b7823879dedb12
Content-Disposition: form-data; name="X-Amz-Date"

20240809T164847Z
--ade4749fd805cf7903338195fac70a2f9a8998eae7f749b7823879dedb12
Content-Disposition: form-data; name="X-Amz-Signature"

d51a75f772782a708f649439105fde6466cd1f3bfb4a1e6e777d7d37d0894e69
--ade4749fd805cf7903338195fac70a2f9a8998eae7f749b7823879dedb12
Content-Disposition: form-data; name="file"; filename="test.txt"
Content-Type: application/octet-stream

--ade4749fd805cf7903338195fac70a2f9a8998eae7f749b7823879dedb12--
'

Context

No

Regression

Yes

Your Environment

  • Version used: v0.30.1
  • Server setup and configuration: devenv
<!--- Provide a general summary of the issue in the Title above --> ## Expected Behavior Post object works as expected https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-UsingHTTPPOST.html ## Current Behavior We get panic: ``` panic: runtime error: invalid memory address or nil pointer dereference -> git.frostfs.info/TrueCloudLab/frostfs-s3-gw/api.NewRouter.Auth.func5.1 -> /home/denis/github/tcl/neofs-s3-gw/api/middleware/auth.go:75 net/http.HandlerFunc.ServeHTTP /home/denis/go/go1.21.6/src/net/http/server.go:2136 git.frostfs.info/TrueCloudLab/frostfs-s3-gw/api.NewRouter.LogSuccessResponse.func4.1 /home/denis/github/tcl/neofs-s3-gw/api/middleware/response.go:304 net/http.HandlerFunc.ServeHTTP /home/denis/go/go1.21.6/src/net/http/server.go:2136 git.frostfs.info/TrueCloudLab/frostfs-s3-gw/api/middleware.stats.func1 /home/denis/github/tcl/neofs-s3-gw/api/middleware/metrics.go:75 net/http.HandlerFunc.ServeHTTP /home/denis/go/go1.21.6/src/net/http/server.go:2136 git.frostfs.info/TrueCloudLab/frostfs-s3-gw/api.NewRouter.Tracing.func2.1 /home/denis/github/tcl/neofs-s3-gw/api/middleware/tracing.go:23 net/http.HandlerFunc.ServeHTTP /home/denis/go/go1.21.6/src/net/http/server.go:2136 github.com/go-chi/chi/v5/middleware.Recoverer.func1 /home/denis/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.8/middleware/recoverer.go:43 net/http.HandlerFunc.ServeHTTP /home/denis/go/go1.21.6/src/net/http/server.go:2136 github.com/go-chi/chi/v5/middleware.ThrottleWithOpts.func1.1 /home/denis/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.8/middleware/throttle.go:100 net/http.HandlerFunc.ServeHTTP /home/denis/go/go1.21.6/src/net/http/server.go:2136 git.frostfs.info/TrueCloudLab/frostfs-s3-gw/api.NewRouter.Request.func1.1 /home/denis/github/tcl/neofs-s3-gw/api/middleware/reqinfo.go:195 net/http.HandlerFunc.ServeHTTP /home/denis/go/go1.21.6/src/net/http/server.go:2136 github.com/go-chi/chi/v5.(*Mux).ServeHTTP /home/denis/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.8/mux.go:90 net/http.serverHandler.ServeHTTP /home/denis/go/go1.21.6/src/net/http/server.go:2938 net/http.(*conn).serve /home/denis/go/go1.21.6/src/net/http/server.go:2009 created by net/http.(*Server).Serve in goroutine 154 /home/denis/go/go1.21.6/src/net/http/server.go:3086 ``` ## Possible Solution ```diff diff --git a/api/auth/center.go b/api/auth/center.go index 72fb7fea..d2c65f56 100644 --- a/api/auth/center.go +++ b/api/auth/center.go @@ -290,7 +290,15 @@ func (c *Center) checkFormData(r *http.Request) (*middleware.Box, error) { reqSignature, signature) } - return &middleware.Box{AccessBox: box, Attributes: attrs}, nil + return &middleware.Box{ + AccessBox: box, + AuthHeaders: &middleware.AuthHeader{ + AccessKeyID: submatches["access_key_id"], + Region: region, + SignatureV4: signature, + }, + Attributes: attrs, + }, nil } func cloneRequest(r *http.Request, authHeader *AuthHeader) *http.Request { diff --git a/api/handler/put.go b/api/handler/put.go index 94cc0f35..308f0a25 100644 --- a/api/handler/put.go +++ b/api/handler/put.go @@ -482,13 +482,22 @@ func (h *handler) PostObject(w http.ResponseWriter, r *http.Request) { } contentReader = file size = uint64(head.Size) - reqInfo.ObjectName = strings.ReplaceAll(reqInfo.ObjectName, "${filename}", head.Filename) + if reqInfo.ObjectName == "" { + reqInfo.ObjectName = head.Filename + } else { + reqInfo.ObjectName = strings.ReplaceAll(reqInfo.ObjectName, "${filename}", head.Filename) + } } if !policy.CheckContentLength(size) { h.logAndSendError(w, "invalid content-length", reqInfo, errors.GetAPIError(errors.ErrInvalidArgument)) return } + if reqInfo.ObjectName == "" { + h.logAndSendError(w, "missing object name", reqInfo, errors.GetAPIError(errors.ErrInvalidArgument)) + return + } + params := &layer.PutObjectParams{ BktInfo: bktInfo, Object: reqInfo.ObjectName, ``` ## Steps to Reproduce (for bugs) Try to upload object from browser using steps from spec https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-post-example.html Request example: ``` curl -X POST http://localhost:8084/test3 \ -H 'Content-Type: multipart/form-data; boundary=ade4749fd805cf7903338195fac70a2f9a8998eae7f749b7823879dedb12' \ --data-binary ' \ --ade4749fd805cf7903338195fac70a2f9a8998eae7f749b7823879dedb12 Content-Disposition: form-data; name="Policy" eyJleHBpcmF0aW9uIjogIjIwMjUtMTItMDFUMTI6MDA6MDAuMDAwWiIsImNvbmRpdGlvbnMiOiBbCiBbInN0YXJ0cy13aXRoIiwgIiR4LWFtei1jcmVkZW50aWFsIiwgIiJdLAogWyJzdGFydHMtd2l0aCIsICIkeC1hbXotZGF0ZSIsICIiXQpdfQ== --ade4749fd805cf7903338195fac70a2f9a8998eae7f749b7823879dedb12 Content-Disposition: form-data; name="X-Amz-Credential" 5jizSbYu8hX345aqCKDgRWKCJYHxnzxRS8e6SUYHZ8Fw0HiRkf3KbJAWBn5mRzmiyHQ3UHADGyzVXLusn1BrmAfLn/20240809T164847Z/default/s3/aws4_request --ade4749fd805cf7903338195fac70a2f9a8998eae7f749b7823879dedb12 Content-Disposition: form-data; name="X-Amz-Date" 20240809T164847Z --ade4749fd805cf7903338195fac70a2f9a8998eae7f749b7823879dedb12 Content-Disposition: form-data; name="X-Amz-Signature" d51a75f772782a708f649439105fde6466cd1f3bfb4a1e6e777d7d37d0894e69 --ade4749fd805cf7903338195fac70a2f9a8998eae7f749b7823879dedb12 Content-Disposition: form-data; name="file"; filename="test.txt" Content-Type: application/octet-stream --ade4749fd805cf7903338195fac70a2f9a8998eae7f749b7823879dedb12-- ' ``` ## Context No ## Regression Yes ## Your Environment <!--- Include as many relevant details about the environment you experienced the bug in --> * Version used: `v0.30.1` * Server setup and configuration: devenv
dkirillov added the
bug
 label 2024-08-09 14:10:02 +00:00
alexvanin added this to the v0.31.0 milestone 2024-11-20 11:48:13 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
support/v0.31
support/v0.30
support/v0.29
support/v0.28
support/v0.27
v0.32.0
v0.31.3
v0.31.2
v0.30.9
v0.31.1
v0.31.0
v0.31.0-rc.6
v0.31.0-rc.5
v0.31.0-rc.4
v0.30.8
v0.31.0-rc.3
v0.30.7
v0.31.0-rc.2
v0.31.0-rc.1
v0.30.6
v0.30.5
v0.30.4
v0.30.3
v0.30.2
v0.30.1
v0.30.0
v0.29.3
v0.30.0-rc.5
v0.29.2
v0.30.0-rc.4
v0.30.0-rc.3
v0.30.0-rc.2
v0.29.1
v0.30.0-rc.1
v0.29.0
v0.28.2
v0.29.0-rc.11
v0.29.0-rc.10
v0.29.0-rc.9
v0.29.0-rc.8
v0.29.0-rc.7
v0.29.0-rc.6
v0.29.0-rc.5
v0.29.0-rc.4
v0.29.0-rc.3
v0.29.0-rc.2
v0.29.0-rc.1
v0.28.1
v0.28.0
v0.28.0-rc.1
v0.27.0
v0.27.0-rc.2
v0.27.0-rc.1
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.31.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#456
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?