TrueCloudLab/frostfs-s3-gw
18
3
Fork 20
Code Issues 29 Pull requests 8 Projects Releases 23 Packages Activity Actions

feature/456-fix_post_policy #457

Merged
dkirillov merged 2 commits from dkirillov/frostfs-s3-gw:feature/456-fix_post_policy into master 2024-09-04 19:51:14 +00:00
Conversation 0 Commits 2 Files changed 4 +229 -26
dkirillov commented 2024-08-12 12:33:55 +00:00
Member
Copy link

close #456

close #456
dkirillov self-assigned this 2024-08-12 12:33:55 +00:00
dkirillov added 2 commits 2024-08-12 12:33:59 +00:00 
During post object operation field AuthHeader in middleware.Box wasn't set
that led to panic

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
[#456] PostObject: check object key for emptiness
All checks were successful
/ Vulncheck (pull_request) Successful in 1m25s
Details
/ DCO (pull_request) Successful in 1m18s
Details
/ Builds (1.21) (pull_request) Successful in 1m30s
Details
/ Builds (1.22) (pull_request) Successful in 1m29s
Details
/ Lint (pull_request) Successful in 2m28s
Details
/ Tests (1.21) (pull_request) Successful in 1m38s
Details
/ Tests (1.22) (pull_request) Successful in 1m33s
Details
b72560885a 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov requested review from storage-services-developers 2024-08-12 12:34:57 +00:00
dkirillov requested review from storage-services-committers 2024-08-12 12:35:01 +00:00
mbiryukova reviewed 2024-08-12 17:18:03 +00:00
api/handler/put_test.go Outdated
@ -452,0 +578,4 @@
return nil, "", err
}
//if key != "" {
mbiryukova commented 2024-08-12 17:18:03 +00:00
Member
Copy link

Can be removed?

Can be removed?
dkirillov commented 2024-08-13 06:26:19 +00:00
Author
Member
Copy link

Oh, sure

Oh, sure
dkirillov force-pushed feature/456-fix_post_policy from b72560885a to 20719bd85c 2024-08-13 06:27:36 +00:00 Compare
mbiryukova approved these changes 2024-08-13 07:02:52 +00:00
pogpp approved these changes 2024-08-13 10:52:27 +00:00
r.loginov approved these changes 2024-08-13 11:08:12 +00:00
dkirillov merged commit 20719bd85c into master 2024-08-13 11:22:05 +00:00
dkirillov deleted branch feature/456-fix_post_policy 2024-08-13 11:22:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
mbiryukova
pogpp
r.loginov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#457
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:feature/456-fix_post_policy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?