TrueCloudLab/frostfs-s3-gw
14
2
Fork 17
Code Issues 22 Pull requests 5 Projects Releases 16 Packages Activity Actions

[#487] Support Range header in object PUT #487

Open
mbiryukova wants to merge 2 commits from mbiryukova/frostfs-s3-gw:feature/put_range into master
pull from: mbiryukova/frostfs-s3-gw:feature/put_range
merge into: TrueCloudLab:master
Conversation 1 Commits 2 Files changed 9 +653 -38
mbiryukova commented 2024-09-10 14:18:15 +00:00
Member
Copy link

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2024-09-10 14:18:15 +00:00
mbiryukova added 1 commit 2024-09-10 14:18:15 +00:00
[#xxx] Support Range header in object PUT
Some checks failed
/ DCO (pull_request) Failing after 1m58s
Details
/ Builds (pull_request) Successful in 2m14s
Details
/ Vulncheck (pull_request) Successful in 2m38s
Details
/ Lint (pull_request) Successful in 4m39s
Details
/ Tests (pull_request) Successful in 6m5s
Details
3f1c423844 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova force-pushed feature/put_range from 3f1c423844 to 5467f44e08 2024-09-10 14:18:38 +00:00 Compare
mbiryukova changed title from [#xxx] Support Range header in object PUT to [#487] Support Range header in object PUT 2024-09-10 14:18:55 +00:00
mbiryukova requested review from storage-services-committers 2024-09-10 14:43:10 +00:00
mbiryukova requested review from storage-services-developers 2024-09-10 14:43:11 +00:00
alexvanin commented 2024-09-11 12:37:57 +00:00
Owner
Copy link

It would be nice to check this PR compatibility with Dell ECS. Therefore I put v0.32.0 milestone for this feature.

It would be nice to check this PR compatibility with Dell ECS. Therefore I put v0.32.0 milestone for this feature.
alexvanin added this to the v0.32.0 milestone 2024-09-11 12:38:01 +00:00
nzinkevich reviewed 2024-09-13 14:14:51 +00:00
api/handler/put.go Outdated
@ -313,0 +459,4 @@
return nil, overwrite, fmt.Errorf("invalid range: %s", rangeStr)
}
}
nzinkevich commented 2024-09-13 14:14:51 +00:00
Member
Copy link

I think it would be better to write if statement instead of switch, e.g.:

if start == -1 && len(endStr) == 0 {
   return &layer.RangeParams{
	  Start: objSize,
	  End:   objSize + contentLen - 1,
   }, overwrite, nil
} else if start < -1 {
   return nil, overwrite, fmt.Errorf("invalid range: %s", rangeStr)
}
I think it would be better to write `if` statement instead of `switch`, e.g.: ```go if start == -1 && len(endStr) == 0 { return &layer.RangeParams{ Start: objSize, End: objSize + contentLen - 1, }, overwrite, nil } else if start < -1 { return nil, overwrite, fmt.Errorf("invalid range: %s", rangeStr) } ```
mbiryukova force-pushed feature/put_range from 5467f44e08 to d6c031ca23 2024-09-16 11:59:14 +00:00 Compare
dkirillov reviewed 2024-09-26 06:46:09 +00:00
api/handler/put.go
@ -313,0 +400,4 @@
return
}
extendedObjInfo, err := h.obj.PatchObject(ctx, params)
dkirillov commented 2024-09-26 06:46:03 +00:00
Member
Copy link

I would try to introduce new method h.patchObject that contains common logic for h.putObjectWithRange and h.PatchObjectHandler

I would try to introduce new method `h.patchObject` that contains common logic for `h.putObjectWithRange` and `h.PatchObjectHandler`
api/handler/put.go
@ -313,0 +448,4 @@
if start == -1 && len(endStr) == 0 {
return &layer.RangeParams{
Start: objSize,
End: objSize + contentLen - 1,
dkirillov commented 2024-09-26 06:42:38 +00:00
Member
Copy link

Why do we use contentLen to find out end of range to patch?

Why do we use contentLen to find out end of range to patch?
api/layer/patch.go
@ -21,6 +21,7 @@ type PatchObjectParams struct {
Range *RangeParams
VersioningEnabled bool
CopiesNumbers []uint32
Overwrite bool
dkirillov commented 2024-09-26 06:32:12 +00:00
Member
Copy link

Why do we need this field? It seems we can just provide correct Range field.

Why do we need this field? It seems we can just provide correct `Range` field.
All checks were successful
/ DCO (pull_request) Successful in 53s
Details
/ Vulncheck (pull_request) Successful in 1m11s
Details
/ Builds (pull_request) Successful in 1m11s
Details
/ Lint (pull_request) Successful in 2m26s
Details
/ Tests (pull_request) Successful in 1m26s
Details
This pull request has changes conflicting with the target branch.
  • api/handler/acl_test.go
  • api/handler/put_test.go
  • api/layer/patch.go
  • go.mod
  • go.sum
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feature/put_range:mbiryukova-feature/put_range
git checkout mbiryukova-feature/put_range
Sign in to join this conversation.
Reviewers
No reviewers
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.32.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#487
No description provided.
Delete branch "mbiryukova/frostfs-s3-gw:feature/put_range"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?