Multinet dialer support #521
No reviewers
Labels
No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No project
No assignees
5 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-s3-gw#521
Loading…
Reference in a new issue
No description provided.
Delete branch "alexvanin/frostfs-s3-gw:feature/multinet"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Adoption of TrueCloudLab/frostfs-node#1422
c101be6af3
to20035065ff
20035065ff
to4e20704a1e
6b0559f917
toa24965daf6
WIP: Multinet dialer supportto Multinet dialer supporta24965daf6
tobea1e2d818
@ -0,0 +8,4 @@
"golang.org/x/sys/unix"
)
func newDefaulDialer() net.Dialer {
Typo:
defaul
vsdefault
Fixed.
@ -0,0 +16,4 @@
// with OS defaults for keepalive time and interval, use a net.Dialer that sets
// the KeepAlive field to a negative value, and sets the SO_KEEPALIVE socket
// option to true from the Control field. For a concrete example of how to do
// this, see internal.NetDialerWithTCPKeepalive().
It seems we also need add some todo
830135e6c5/internal/tcp_keepalive_unix.go (L33C15-L33C56)
?
Updated.
@ -0,0 +25,4 @@
}
func (s *DialerSource) build(c Config) error {
if c.Enabled {
Can we invert condition to reduce
if
block length?I don't mind but I've tried to keep code the same with storage node, so it will be easier to fix things here and there. What you prefer more, having similar code or fixing code style?
I don't have a strong opinion
I've decided to keep code the same with frostfs-node.
@ -0,0 +60,4 @@
// NetContextDialer returns net.DialContext dial function.
// Returns nil if multinet disabled.
func (s *DialerSource) NetContextDialer() func(context.Context, string, string) (net.Conn, error) {
Currently this is unused. Do we really need add this right now?
Sure, missed that. I've already removed some unused code from storage implementation such as DialContextTCP
Fixed.
bea1e2d818
to53fdf52178
LGTM
53fdf52178
to8bc19725ba