TrueCloudLab/frostfs-s3-gw
18
3
Fork 20
Code Issues 29 Pull requests 7 Projects Releases 23 Packages 1 Activity Actions

bugfix/lifecycle #544

Merged
alexvanin merged 3 commits from mbiryukova/frostfs-s3-gw:bugfix/lifecycle into master 2024-11-12 12:51:03 +00:00
Conversation 0 Commits 3 Files changed 3 +173 -46
mbiryukova commented 2024-11-08 08:49:55 +00:00
Member
Copy link

Closes #536

Closes #536
mbiryukova self-assigned this 2024-11-08 08:49:55 +00:00
mbiryukova added 3 commits 2024-11-08 08:49:55 +00:00 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
[#536] Add rule ID generation
All checks were successful
/ DCO (pull_request) Successful in 1m31s
Details
/ Vulncheck (pull_request) Successful in 1m31s
Details
/ Builds (pull_request) Successful in 1m50s
Details
/ Lint (pull_request) Successful in 2m22s
Details
/ Tests (pull_request) Successful in 1m49s
Details
c32fb46fce 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova requested review from storage-services-committers 2024-11-08 09:11:54 +00:00
mbiryukova requested review from storage-services-developers 2024-11-08 09:11:55 +00:00
dkirillov reviewed 2024-11-11 07:42:17 +00:00
api/handler/lifecycle_test.go Outdated
@ -30,3 +30,3 @@
name string
body *data.LifecycleConfiguration
error bool
error apierr.ErrorCode
dkirillov commented 2024-11-11 07:42:17 +00:00
Member
Copy link

Let's rename this to errorCode or change type of field to error

Let's rename this to `errorCode` or change type of field to `error`
👀 1
dkirillov marked this conversation as resolved
dkirillov approved these changes 2024-11-11 07:42:22 +00:00
Dismissed
mbiryukova force-pushed bugfix/lifecycle from c32fb46fce to af7fa5f62e 2024-11-11 08:18:08 +00:00 Compare
mbiryukova dismissed dkirillov's review 2024-11-11 08:18:08 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dkirillov approved these changes 2024-11-11 09:11:30 +00:00
alexvanin approved these changes 2024-11-12 12:50:49 +00:00
alexvanin merged commit 7ab902d8d2 into master 2024-11-12 12:51:03 +00:00
alexvanin deleted branch bugfix/lifecycle 2024-11-12 12:51:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#544
No description provided.
Delete branch "mbiryukova/frostfs-s3-gw:bugfix/lifecycle"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?