Support context cancellation in tree node streaming #569

New issue

Closed

opened 2024-12-06 08:38:48 +00:00 by dkirillov · 1 comment

dkirillov commented

2024-12-06 08:38:48 +00:00

Member

It would be nice to support context cancellation during streaming nodes from tree.

here

func (s *VersionsByPrefixStreamImpl) Next(context.Context) (*data.NodeVersion, error) {

and here

func (s *SubTreeStreamImpl) Next() (tree.NodeResponse, error) {

Describe the solution you'd like

Check context here and return error rather than returning up to 1000 buffered values.

Describe alternatives you've considered

Additional context

It can help cancel lifecycle cycle in https://git.frostfs.info/TrueCloudLab/frostfs-s3-lifecycler

## Is your feature request related to a problem? Please describe. It would be nice to support context cancellation during streaming nodes from tree. here https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/f215d200e8979468b52ca94237151d06fd1d5766/pkg/service/tree/tree.go#L938 and here https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/f215d200e8979468b52ca94237151d06fd1d5766/internal/frostfs/services/pool_wrapper.go#L155 ## Describe the solution you'd like Check context [here](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/f215d200e8979468b52ca94237151d06fd1d5766/internal/frostfs/services/pool_wrapper.go#L155) and return error rather than returning up to 1000 buffered values. ## Describe alternatives you've considered No ## Additional context It can help cancel lifecycle cycle in https://git.frostfs.info/TrueCloudLab/frostfs-s3-lifecycler