TrueCloudLab/frostfs-s3-gw
18
3
Fork 20
Code Issues 29 Pull requests 7 Projects Releases 23 Packages 1 Activity Actions

[#569] Support context cancellation in tree node streaming #571

Merged
alexvanin merged 1 commit from nzinkevich/frostfs-s3-gw:cancel_tree_stream into master 2024-12-24 08:05:45 +00:00
Conversation 0 Commits 1 Files changed 5 +105 -15
nzinkevich commented 2024-12-10 10:29:06 +00:00
Member
Copy link

Signed-off-by: Nikita Zinkevich n.zinkevich@yadro.com

Signed-off-by: Nikita Zinkevich <n.zinkevich@yadro.com>
nzinkevich self-assigned this 2024-12-10 10:29:06 +00:00
nzinkevich added 1 commit 2024-12-10 10:29:07 +00:00
[#569] Support context cancellation in tree node streaming
All checks were successful
/ DCO (pull_request) Successful in 2m32s
Details
/ Vulncheck (pull_request) Successful in 2m41s
Details
/ Builds (pull_request) Successful in 2m8s
Details
/ Lint (pull_request) Successful in 3m10s
Details
/ Tests (pull_request) Successful in 2m10s
Details
423d9ef120 
Signed-off-by: Nikita Zinkevich <n.zinkevich@yadro.com>
nzinkevich requested review from alexvanin 2024-12-10 10:29:07 +00:00
nzinkevich requested review from dkirillov 2024-12-10 10:29:07 +00:00
nzinkevich requested review from storage-services-committers 2024-12-10 10:29:18 +00:00
nzinkevich requested review from storage-services-developers 2024-12-10 10:29:20 +00:00
dkirillov reviewed 2024-12-10 14:53:09 +00:00
pkg/service/tree/tree.go Outdated
@ -942,2 +942,4 @@
for {
select {
case <-ctx.Done():
dkirillov commented 2024-12-10 14:53:09 +00:00
Member
Copy link

It seems we can rely on inner context cancellation (I mean inside SubTreeStream.Next)

It seems we can rely on inner context cancellation (I mean inside `SubTreeStream.Next`)
👍 1
dkirillov marked this conversation as resolved
dkirillov reviewed 2024-12-10 14:54:50 +00:00
pkg/service/tree/tree.go Outdated
@ -936,3 +936,3 @@
}
func (s *VersionsByPrefixStreamImpl) Next(context.Context) (*data.NodeVersion, error) {
func (s *VersionsByPrefixStreamImpl) Next(ctx context.Context) (*data.NodeVersion, error) {
dkirillov commented 2024-12-10 14:54:50 +00:00
Member
Copy link

It would be nice to test this. It require update SubTreeStreamMemoryImpl a little I suppose, but still.

It would be nice to test this. It require update `SubTreeStreamMemoryImpl` a little I suppose, but still.
dkirillov marked this conversation as resolved
alexvanin added this to the v0.33.0 milestone 2024-12-11 07:39:22 +00:00
nzinkevich force-pushed cancel_tree_stream from 423d9ef120 to d0f1446630 2024-12-11 09:54:49 +00:00 Compare
nzinkevich force-pushed cancel_tree_stream from d0f1446630 to c85ac53de0 2024-12-11 09:54:58 +00:00 Compare
dkirillov approved these changes 2024-12-13 12:00:11 +00:00
Dismissed
nzinkevich requested review from storage-services-committers 2024-12-16 09:26:06 +00:00
nzinkevich requested review from storage-services-developers 2024-12-16 09:26:12 +00:00
nzinkevich force-pushed cancel_tree_stream from c85ac53de0 to 95b3296593 2024-12-16 09:27:05 +00:00 Compare
nzinkevich dismissed dkirillov's review 2024-12-16 09:27:09 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dkirillov approved these changes 2024-12-16 12:46:30 +00:00
mbiryukova approved these changes 2024-12-20 10:31:27 +00:00
alexvanin approved these changes 2024-12-24 08:04:58 +00:00
alexvanin merged commit d46f1d3bfa into master 2024-12-24 08:05:45 +00:00
alexvanin deleted branch cancel_tree_stream 2024-12-24 08:05:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
mbiryukova
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.33.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nzinkevich
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#571
No description provided.
Delete branch "nzinkevich/frostfs-s3-gw:cancel_tree_stream"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?