TrueCloudLab/frostfs-s3-gw
17
3
Fork 20
Code Issues 28 Pull requests 9 Projects Releases 26 Packages 1 Activity Actions

[#615] Use UNSIGNED_PAYLOAD to check sign #615

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:bugfix/fix_check_signature_with_unsigned_payload into master 2025-01-30 13:16:40 +00:00
Conversation 2 Commits 1 Files changed 6 +142 -23
dkirillov commented 2025-01-28 15:01:42 +00:00
Member
Copy link

Use UNSIGNED_PAYLOAD to check signature if x-amz-content-sha256 isn't provided as signed header

https://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-header-based-auth.html

" You include the literal string UNSIGNED-PAYLOAD when constructing a canonical request, and set the same value as the x-amz-content-sha256 header value when sending the request to Amazon S3"

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Use `UNSIGNED_PAYLOAD` to check signature if x-amz-content-sha256 isn't provided as signed header https://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-header-based-auth.html " You include the literal string UNSIGNED-PAYLOAD when constructing a canonical request, and set the same value as the x-amz-content-sha256 header value when sending the request to Amazon S3" Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2025-01-28 15:01:42 +00:00
dkirillov added 1 commit 2025-01-28 15:01:42 +00:00
[#XX] Use UNSIGNED_PAYLOAD to check sign
Some checks failed
/ DCO (pull_request) Failing after 32s
Details
/ Vulncheck (pull_request) Successful in 59s
Details
/ OCI image (pull_request) Successful in 2m29s
Details
/ Builds (pull_request) Successful in 2m31s
Details
/ Lint (pull_request) Successful in 3m15s
Details
/ Tests (pull_request) Successful in 1m10s
Details
317fb1ac6b 
Use `UNSIGNED_PAYLOAD` to check signature if x-amz-content-sha256 isn't provided as signed header

https://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-header-based-auth.html

" You include the literal string UNSIGNED-PAYLOAD when constructing a canonical request, and set the same value as the x-amz-content-sha256 header value when sending the request to Amazon S3"

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov requested review from storage-services-committers 2025-01-28 15:01:42 +00:00
dkirillov requested review from storage-services-developers 2025-01-28 15:01:42 +00:00
dkirillov force-pushed bugfix/fix_check_signature_with_unsigned_payload from 317fb1ac6b to 3d5981e225 2025-01-28 15:02:32 +00:00 Compare
dkirillov changed title from [#XX] Use UNSIGNED_PAYLOAD to check sign to [#615] Use UNSIGNED_PAYLOAD to check sign 2025-01-28 15:03:06 +00:00
dkirillov force-pushed bugfix/fix_check_signature_with_unsigned_payload from 3d5981e225 to b1eeb7e7ab 2025-01-29 08:03:19 +00:00 Compare
dkirillov force-pushed bugfix/fix_check_signature_with_unsigned_payload from b1eeb7e7ab to 894faf0e65 2025-01-29 09:37:25 +00:00 Compare
dkirillov force-pushed bugfix/fix_check_signature_with_unsigned_payload from 894faf0e65 to aeaeb62e3b 2025-01-29 09:45:55 +00:00 Compare
alexvanin commented 2025-01-29 12:05:10 +00:00
Owner
Copy link

@dkirillov can you add commit with the port of changelog data? It is not necessary but will be good to keep changelog relevant in master branch

@dkirillov can you add commit with the port of changelog data? It is not necessary but will be good to keep changelog relevant in master branch
alexvanin commented 2025-01-30 13:16:12 +00:00
Owner
Copy link

@dkirillov can you add commit with the port of changelog data? It is not necessary but will be good to keep changelog relevant in master branch

I'll do it in my PR with SDK update.

> @dkirillov can you add commit with the port of changelog data? It is not necessary but will be good to keep changelog relevant in master branch I'll do it in my PR with SDK update.
alexvanin approved these changes 2025-01-30 13:16:26 +00:00
alexvanin merged commit 3d3dd00211 into master 2025-01-30 13:16:40 +00:00
alexvanin deleted branch bugfix/fix_check_signature_with_unsigned_payload 2025-01-30 13:16:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#615
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:bugfix/fix_check_signature_with_unsigned_payload"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?