TrueCloudLab/frostfs-s3-gw
15
3
Fork 18
Code Issues 28 Pull requests 5 Projects Releases 17 Packages Activity Actions

[#178] wrapReader: Fix goroutine leak #178

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:bugfix/put_object_goroutine_leak_fix into master 2023-08-02 14:29:03 +00:00
Conversation 0 Commits 1 Files changed 4 +49 -9
dkirillov commented 2023-08-01 14:58:24 +00:00
Member
Copy link

In case of error in FrostFS.CreateObject wrapped reader
can be blocked because of synchronous pipe. We have to read out all payload in such case.

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

In case of error in FrostFS.CreateObject wrapped reader can be blocked because of synchronous pipe. We have to read out all payload in such case. Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2023-08-01 14:58:24 +00:00
dkirillov changed title from WIP: [#XX] wrapReader: Fix goroutine leak to WIP: [#178] wrapReader: Fix goroutine leak 2023-08-01 14:58:46 +00:00
dkirillov force-pushed bugfix/put_object_goroutine_leak_fix from 8e256c17b9 to fe897ec588 2023-08-01 14:59:59 +00:00 Compare
dkirillov changed title from WIP: [#178] wrapReader: Fix goroutine leak to [#178] wrapReader: Fix goroutine leak 2023-08-01 15:00:27 +00:00
dkirillov requested review from storage-services-committers 2023-08-01 15:00:40 +00:00
dkirillov requested review from storage-services-developers 2023-08-01 15:00:43 +00:00
alexvanin approved these changes 2023-08-02 14:28:40 +00:00
alexvanin added this to the v0.28.0 milestone 2023-08-02 14:28:46 +00:00
alexvanin added the
bug
 label 2023-08-02 14:28:52 +00:00
alexvanin merged commit fe897ec588 into master 2023-08-02 14:29:03 +00:00
alexvanin deleted branch bugfix/put_object_goroutine_leak_fix 2023-08-02 14:29:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.28.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#178
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:bugfix/put_object_goroutine_leak_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?