TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 6 Projects Releases 18 Packages Activity Actions

[#199] Add metrics for HTTP endpoint status #201

Merged
alexvanin merged 1 commit from mbiryukova/frostfs-s3-gw:feature/add_metrics_for_http_endpoints into master 2023-09-05 13:30:29 +00:00
Conversation 0 Commits 1 Files changed 5 +79 -10
mbiryukova commented 2023-08-30 07:41:34 +00:00
Member
Copy link

Closes #199

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Closes #199 Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2023-08-30 07:41:34 +00:00
mbiryukova requested review from storage-services-committers 2023-08-30 07:52:25 +00:00
mbiryukova requested review from storage-services-developers 2023-08-30 07:52:25 +00:00
mbiryukova force-pushed feature/add_metrics_for_http_endpoints from d7a9835951 to ea23c69838 2023-08-30 08:14:36 +00:00 Compare
alexvanin approved these changes 2023-08-31 11:52:25 +00:00
alexvanin left a comment
Owner
Copy link

Overall LGTM

Overall LGTM
metrics/http.go Outdated
@ -0,0 +3,4 @@
import "github.com/prometheus/client_golang/prometheus"
const (
httpServerSubsystem = "http_server"
alexvanin commented 2023-08-31 11:51:00 +00:00
Owner
Copy link

Let's use server here too as in HTTP gateway. S3 works only through http protocol.

Let's use `server` here too as in HTTP gateway. S3 works only through http protocol.
mbiryukova force-pushed feature/add_metrics_for_http_endpoints from ea23c69838 to 02e7d71bd7 2023-08-31 12:00:51 +00:00 Compare
mbiryukova force-pushed feature/add_metrics_for_http_endpoints from 02e7d71bd7 to 63cdc9f0d7 2023-08-31 12:03:43 +00:00 Compare
dkirillov reviewed 2023-08-31 13:21:14 +00:00
metrics/desc.go Outdated
@ -137,0 +140,4 @@
Namespace: namespace,
Subsystem: serverSubsystem,
Name: httpHealthMetric,
Help: "HTTP Server endpoint health",
dkirillov commented 2023-08-31 13:21:14 +00:00
Member
Copy link

Probably we should use S3 Server endpoint health

Probably we should use ` S3 Server endpoint health`
mbiryukova commented 2023-08-31 14:45:21 +00:00
Author
Member
Copy link

I thought it's name of protocol (http/grpc)

I thought it's name of protocol (http/grpc)
dkirillov marked this conversation as resolved
dkirillov approved these changes 2023-08-31 13:22:42 +00:00
mbiryukova force-pushed feature/add_metrics_for_http_endpoints from 63cdc9f0d7 to f912a89faa 2023-08-31 15:28:02 +00:00 Compare
dkirillov approved these changes 2023-09-01 10:55:37 +00:00
mbiryukova force-pushed feature/add_metrics_for_http_endpoints from f912a89faa to 879e2bb695 2023-09-04 10:14:36 +00:00 Compare
ironbee approved these changes 2023-09-05 10:00:31 +00:00
alexvanin merged commit 69227b4845 into master 2023-09-05 13:30:29 +00:00
alexvanin deleted branch feature/add_metrics_for_http_endpoints 2023-09-05 13:30:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
dkirillov
ironbee
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#201
No description provided.
Delete branch "mbiryukova/frostfs-s3-gw:feature/add_metrics_for_http_endpoints"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?