TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 7 Projects Releases 18 Packages Activity Actions

[#196] Support soft memory limit setting #202

Merged
alexvanin merged 1 commit from :feature/196-support_soft_memory_limit into master 2023-09-05 13:13:57 +00:00
Conversation 0 Commits 1 Files changed 6 +55
r.loginov commented 2023-08-31 05:58:03 +00:00
Member
Copy link

close #196

Signed-off-by: Roman Loginov r.loginov@yadro.com

close #196 Signed-off-by: Roman Loginov <r.loginov@yadro.com>
r.loginov self-assigned this 2023-08-31 05:58:03 +00:00
r.loginov requested review from storage-services-committers 2023-08-31 05:58:29 +00:00
r.loginov requested review from storage-services-developers 2023-08-31 05:58:30 +00:00
alexvanin reviewed 2023-08-31 11:18:13 +00:00
cmd/s3-gw/app.go Outdated
@ -682,0 +687,4 @@
func (a *App) setRuntimeParameters(l *zap.Logger, cfg *viper.Viper) {
if len(os.Getenv("GOMEMLIMIT")) != 0 {
// default limit < yaml limit < app env limit < GOMEMLIMIT
l.Warn(logs.RuntimeSoftMemoryDefinedWithGOMEMLIMIT)
alexvanin commented 2023-08-31 11:14:05 +00:00
Owner
Copy link

Can't we use logger from a.log?

Can't we use logger from `a.log`?
👍 1
alexvanin marked this conversation as resolved
alexvanin reviewed 2023-08-31 11:20:24 +00:00
docs/configuration.md Outdated
@ -550,0 +559,4 @@
| Parameter | Type | SIGHUP reload | Default value | Description |
|---------------------|-----------|---------------|---------------|--------------------------------------------------------------------------|
| `soft_memory_limit` | `size` | yes | 0 | Soft memory limit for the runtime. Zero or no value stands for no limit. If `GOMEMLIMIT` environment variable is set, the value from the configuration file will be ignored. |
alexvanin commented 2023-08-31 11:20:24 +00:00
Owner
Copy link

Actually default is maxint64.

Actually default is maxint64.
👍 1
alexvanin marked this conversation as resolved
r.loginov force-pushed feature/196-support_soft_memory_limit from 85cd9d9d7f to 2d9477927a 2023-08-31 11:57:48 +00:00 Compare
r.loginov force-pushed feature/196-support_soft_memory_limit from 2d9477927a to 026946b796 2023-08-31 12:14:38 +00:00 Compare
dkirillov reviewed 2023-08-31 13:27:41 +00:00
docs/configuration.md Outdated
@ -550,0 +558,4 @@
```
| Parameter | Type | SIGHUP reload | Default value | Description |
|---------------------|-----------|---------------|---------------|--------------------------------------------------------------------------|
dkirillov commented 2023-08-31 13:27:41 +00:00
Member
Copy link

Please reformat table

Please reformat table
👍 1
dkirillov marked this conversation as resolved
dkirillov reviewed 2023-08-31 13:27:52 +00:00
docs/configuration.md Outdated
@ -185,6 +185,7 @@ There are some custom types used for brevity:
| `frostfs` | [Parameters of requests to FrostFS](#frostfs-section) |
| `resolve_bucket` | [Bucket name resolving configuration](#resolve_bucket-section) |
| `kludge` | [Different kludge configuration](#kludge-section) |
| `runtime` | [Runtime configuration](#runtime-section) |
dkirillov commented 2023-08-31 13:27:52 +00:00
Member
Copy link

Please, reformat table

Please, reformat table
👍 1
dkirillov marked this conversation as resolved
r.loginov force-pushed feature/196-support_soft_memory_limit from 026946b796 to 25eb12da91 2023-08-31 14:37:15 +00:00 Compare
r.loginov force-pushed feature/196-support_soft_memory_limit from 25eb12da91 to 8eac5bcde3 2023-08-31 14:41:46 +00:00 Compare
dkirillov approved these changes 2023-09-01 09:21:48 +00:00
ironbee approved these changes 2023-09-05 09:59:41 +00:00
alexvanin approved these changes 2023-09-05 13:13:52 +00:00
alexvanin merged commit c66c09765d into master 2023-09-05 13:13:57 +00:00
alexvanin deleted branch feature/196-support_soft_memory_limit 2023-09-05 13:13:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
ironbee
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
r.loginov
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#202
No description provided.
Delete branch ":feature/196-support_soft_memory_limit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?