[#152] authmate: Add basic error types and exit codes #204

ironbee · 2023-09-04T18:09:09Z

ironbee commented

2023-09-04 18:09:09 +00:00

Signed-off-by: Artem Tataurov a.tataurov@yadro.com

From the issue:

Pull request adds the following errors:

preparationError - various error related to initialisation, parsing provided arguments, acquiring intermediate data.
frostFSInitError - errors related to FrostFS functioning.
businessLogicError - errors in main (business) goals of the authmate's modules.
This is an initial classification and may be changed an/or extended in future.

Closes #152.

Signed-off-by: Artem Tataurov <a.tataurov@yadro.com> From the issue: > Pull request adds the following errors: > > preparationError - various error related to initialisation, parsing provided arguments, acquiring intermediate data. > frostFSInitError - errors related to FrostFS functioning. > businessLogicError - errors in main (business) goals of the authmate's modules. > This is an initial classification and may be changed an/or extended in future. > Closes #152.

ironbee requested review from storage-services-committers 2023-09-04 18:09:23 +00:00

ironbee requested review from storage-services-developers 2023-09-04 18:09:24 +00:00

ironbee force-pushed add_error_types_to_authmate from 3a12d4bbf4 to d5bba6c4d6

2023-09-04 19:24:52 +00:00

Compare

mbiryukova approved these changes 2023-09-05 11:37:39 +00:00

alexvanin reviewed 2023-09-05 13:28:26 +00:00

cmd/s3-authmate/modules/errors.go Outdated

					
				@ -0,0 +39,4 @@

				}

				func (e businessLogicError) Error() string {

					return fmt.Sprintf("business logic error: %v", e.err)

alexvanin commented

2023-09-05 13:28:26 +00:00

suggestion: Return just e.err in all these cases without text wrapping. Instead define return code + meaning relation in docs/authmate.md in a table format. In the table you can provide more info, e.g.

Code	Meaning
2	Error in preparation step when user data is parsed

**suggestion**: Return just `e.err` in all these cases without text wrapping. Instead define return code + meaning relation in `docs/authmate.md` in a table format. In the table you can provide more info, e.g. |Code|Meaning| |-|-| | 2 | Error in preparation step when user data is parsed|

👍 1