[#216] Add check tag key uniqueness #238

Merged

alexvanin merged 1 commit from :feature/216-add_check_tag_key_uniqueness into master

2023-10-17 14:40:31 +00:00

r.loginov commented

2023-10-12 08:29:46 +00:00

Member

Closes #216

Also corrected the contents of error messages ErrInvalidTagKey and ErrInvalidTagValue.

Signed-off-by: Roman Loginov r.loginov@yadro.com

Closes #216 Also corrected the contents of error messages [ErrInvalidTagKey](https://git.frostfs.info/r.loginov/frostfs-s3-gw/src/commit/982e556ec032ab5cabfeaf40d116bccf56c1e3db/api/errors/errors.go#L530) and [ErrInvalidTagValue](https://git.frostfs.info/r.loginov/frostfs-s3-gw/src/commit/982e556ec032ab5cabfeaf40d116bccf56c1e3db/api/errors/errors.go#L536). Signed-off-by: Roman Loginov <r.loginov@yadro.com>

r.loginov self-assigned this 2023-10-12 08:29:47 +00:00

r.loginov requested review from storage-services-committers 2023-10-12 08:43:50 +00:00

r.loginov requested review from storage-services-developers 2023-10-12 08:43:51 +00:00

dkirillov approved these changes 2023-10-13 08:07:20 +00:00

dkirillov left a comment

Member

Can we add test for this?

r.loginov commented

2023-10-13 09:59:55 +00:00

Author

Member

Can we add test for this?

Yes, then maybe it's better to put this in a separate function for convenient testing? Or is it a bad idea? @dkirillov

> Can we add test for this? Yes, then maybe it's better to put [this](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/982e556ec032ab5cabfeaf40d116bccf56c1e3db/api/handler/tagging.go#L221-L227) in a separate function for convenient testing? Or is it a bad idea? @dkirillov

dkirillov commented

2023-10-13 11:06:00 +00:00

Member

I meant add test that invoke handlers (not just small funtion) similar to this

func TestCopyWithTaggingDirective(t *testing.T) {

I meant add test that invoke handlers (not just small funtion) similar to this https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/10a03faeb4b315728e616dc8ddf0bb22bbdab243/api/handler/copy_test.go#L21

👍 1

r.loginov force-pushed feature/216-add_check_tag_key_uniqueness from 982e556ec0 to f14008d11c

2023-10-16 06:22:21 +00:00

Compare

dkirillov approved these changes 2023-10-16 06:48:01 +00:00