[#223] Add store content language #240

Merged
alexvanin merged 1 commit from :feature/223-add_store_content_language into master 2023-10-17 14:42:04 +00:00
Member

Closes #223

Signed-off-by: Roman Loginov r.loginov@yadro.com

Closes #223 Signed-off-by: Roman Loginov <r.loginov@yadro.com>
r.loginov self-assigned this 2023-10-16 17:20:49 +00:00
dkirillov reviewed 2023-10-17 06:24:09 +00:00
@ -734,3 +734,3 @@
func IsSystemHeader(key string) bool {
_, ok := api.SystemMetadata[key]
return ok || strings.HasPrefix(key, api.FrostFSSystemMetadataPrefix)
return ok || strings.HasPrefix(key, api.FrostFSSystemMetadataPrefix) || key == api.ContentLanguage
Member

Let's add api.ContentLanguage to api.SystemMetadata map

Let's add `api.ContentLanguage` to `api.SystemMetadata` map
dkirillov marked this conversation as resolved
dkirillov approved these changes 2023-10-17 06:25:12 +00:00
dkirillov left a comment
Member

It would be nice to have tests to check that we successfully store and retrieve content language header

It would be nice to have tests to check that we successfully store and retrieve content language header
r.loginov force-pushed feature/223-add_store_content_language from 6672cbb82f to 91de5d8d3c 2023-10-17 09:04:49 +00:00 Compare
r.loginov requested review from storage-services-committers 2023-10-17 09:05:46 +00:00
r.loginov requested review from storage-services-developers 2023-10-17 09:05:47 +00:00
dkirillov reviewed 2023-10-17 11:27:19 +00:00
@ -256,0 +262,4 @@
partSize := 5 * 1024 * 1024
exceptedContentLanguage := "en"
headers := map[string]string{
"Content-Language": exceptedContentLanguage,
Member

Why don't we use api.ContentLanguage constant?

Why don't we use `api.ContentLanguage` constant?
dkirillov approved these changes 2023-10-17 11:27:45 +00:00
r.loginov force-pushed feature/223-add_store_content_language from 91de5d8d3c to 96968d0b1e 2023-10-17 12:18:42 +00:00 Compare
alexvanin approved these changes 2023-10-17 14:41:57 +00:00
alexvanin merged commit 7e91f62c28 into master 2023-10-17 14:42:04 +00:00
alexvanin deleted branch feature/223-add_store_content_language 2023-10-17 14:42:05 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-services-developers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#240
No description provided.