TrueCloudLab/frostfs-s3-gw
17
3
Fork 20
Code Issues 26 Pull requests 7 Projects Releases 34 Packages 1 Activity Actions

Clean tag node in the tree service instead of removal #244

Merged
alexvanin merged 1 commit from alexvanin/frostfs-s3-gw:fix/tag-delete/v0.28 into support/v0.28 2023-10-18 09:46:15 +00:00
Conversation 1 Commits 1 Files changed 2 +4 -28
alexvanin commented 2023-10-18 08:56:36 +00:00
Owner
Copy link

With new retry policy of tree service pool, gateway should avoid deletion of system nodes from tree. Absence of node in the tree will trigger retry. Other storage in the network may return already
deleted node while tree is not completely synced, and client will get unexpected result.

With new retry policy of tree service pool, gateway should avoid deletion of system nodes from tree. Absence of node in the tree will trigger retry. Other storage in the network may return already deleted node while tree is not completely synced, and client will get unexpected result.
alexvanin added 1 commit 2023-10-18 08:56:40 +00:00
[#233] Clean tag node in the tree service instead of removal
All checks were successful
/ DCO (pull_request) Successful in 1m49s
Details
/ Vulncheck (pull_request) Successful in 2m10s
Details
/ Builds (1.20) (pull_request) Successful in 2m26s
Details
/ Builds (1.21) (pull_request) Successful in 2m17s
Details
/ Lint (pull_request) Successful in 4m21s
Details
/ Tests (1.20) (pull_request) Successful in 2m15s
Details
/ Tests (1.21) (pull_request) Successful in 2m10s
Details
e87c3715c5 
With new retry policy of tree service pool, gateway should avoid
deletion of system nodes from tree. Absence of node in the tree
will trigger retry. Other storage in the network may return already
deleted node while tree is not completely synced, and client will
get unexpected result.

Signed-off-by: Alex Vanin <a.vanin@yadro.com>
alexvanin commented 2023-10-18 08:56:57 +00:00
Author
Owner
Copy link

Master branch port is included in #233

Master branch port is included in https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/pulls/233
requested reviews from dkirillov, pogpp, ironbee, JuliaKovshova, mbiryukova, r.loginov 2023-10-18 08:58:11 +00:00
JuliaKovshova approved these changes 2023-10-18 09:02:25 +00:00
dkirillov approved these changes 2023-10-18 09:07:45 +00:00
mbiryukova approved these changes 2023-10-18 09:16:26 +00:00
alexvanin merged commit e87c3715c5 into support/v0.28 2023-10-18 09:46:15 +00:00
alexvanin deleted branch fix/tag-delete/v0.28 2023-10-18 09:46:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pogpp
ironbee
r.loginov
JuliaKovshova
dkirillov
mbiryukova
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#244
No description provided.
Delete branch "alexvanin/frostfs-s3-gw:fix/tag-delete/v0.28"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?