TrueCloudLab
/
frostfs-s3-gw
16
2
Fork 14
Code Issues 19 Pull Requests 4 Actions Packages Releases 6 Activity

[#205] Add md5 checksum in ETag by config param #256

Merged
alexvanin merged 1 commits from mbiryukova/frostfs-s3-gw:feature/add_md5_checksum into support/v0.28 2023-12-07 12:20:15 +00:00
Conversation 1 Commits 1 Files Changed 30
mbiryukova commented 2023-10-30 09:34:25 +00:00
Collaborator

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2023-10-30 09:34:25 +00:00
mbiryukova requested review from storage-services-committers 2023-10-30 09:42:13 +00:00
mbiryukova requested review from storage-services-developers 2023-10-30 09:42:13 +00:00
dkirillov approved these changes 2023-10-30 13:37:29 +00:00
dkirillov commented 2023-10-30 14:42:49 +00:00
Collaborator

Consider #255 (comment)

Consider https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/pulls/255#issuecomment-24858
dkirillov reviewed 2023-10-31 12:05:02 +00:00
api/layer/object.go Outdated
@ -465,3 +490,4 @@
prm.Payload = wrapReader(prm.Payload, 64*1024, func(buf []byte) {
size += uint64(len(buf))
hash.Write(buf)
md5Hash.Write(buf)
dkirillov commented 2023-10-31 12:05:02 +00:00
Collaborator

Consider this comment #228 (comment)

Consider this comment https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/pulls/228#issuecomment-22637
alexvanin requested changes 2023-10-31 13:59:48 +00:00
alexvanin left a comment
Owner

Blocking comment to avoid accidental merging before v0.28.0 release.

Blocking comment to avoid accidental merging before v0.28.0 release.
mbiryukova force-pushed feature/add_md5_checksum from f8030d77cd to d901f4bf9b 2023-10-31 14:02:33 +00:00 Compare
mbiryukova force-pushed feature/add_md5_checksum from d901f4bf9b to 7e9294c4bb 2023-11-01 10:43:44 +00:00 Compare
alexvanin added this to the v0.28.1 milestone 2023-11-07 11:47:37 +00:00
alexvanin approved these changes 2023-12-07 12:19:53 +00:00
alexvanin merged commit aa2c016f83 into support/v0.28 2023-12-07 12:20:15 +00:00
alexvanin deleted branch feature/add_md5_checksum 2023-12-07 12:20:16 +00:00
alexvanin removed this from the v0.28.1 milestone 2024-01-24 11:55:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
mbiryukova
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#256
There is no content yet.
Delete Branch "mbiryukova/frostfs-s3-gw:feature/add_md5_checksum"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?