TrueCloudLab/frostfs-s3-gw
15
2
Fork 16
Code Issues 20 Pull requests 4 Projects Releases 13 Packages Activity Actions

feature/260-support_frostfsid #265

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:feature/260-support_frostfsid into master 2024-09-04 19:51:12 +00:00
Conversation 0 Commits 1 Files changed 12 +87 -37
dkirillov commented 2023-11-16 12:13:28 +00:00
Member
Copy link

close #260

close #260
dkirillov self-assigned this 2023-11-16 12:13:28 +00:00
dkirillov changed title from WIP: feature/260-support_frostfsid to feature/260-support_frostfsid 2023-11-16 12:14:53 +00:00
dkirillov requested review from storage-services-committers 2023-11-16 12:15:01 +00:00
dkirillov requested review from storage-services-developers 2023-11-16 12:15:03 +00:00
dkirillov force-pushed feature/260-support_frostfsid from ced5787694 to fb80f8029f 2023-11-20 08:49:28 +00:00 Compare
dkirillov force-pushed feature/260-support_frostfsid from fb80f8029f to fcd56432a9 2023-11-20 11:41:11 +00:00 Compare
dkirillov force-pushed feature/260-support_frostfsid from fcd56432a9 to 363d6559a7 2023-11-21 10:12:21 +00:00 Compare
alexvanin reviewed 2023-11-22 12:02:59 +00:00
api/cache/buckets.go Outdated
@ -58,3 +59,2 @@
// Put puts an object to cache.
func (o *BucketCache) Put(bkt *data.BucketInfo) error {
return o.cache.Set(bkt.Name, bkt)
func (o *BucketCache) Put(ns string, bkt *data.BucketInfo) error {
alexvanin commented 2023-11-22 11:44:57 +00:00
Owner
Copy link

Is it too bad to keep namespace string as a part of BucketInfo struct? Technically it is bucket info when bucket is created.

Is it too bad to keep namespace string as a part of BucketInfo struct? Technically it is bucket info when bucket is created.
api/middleware/auth.go Outdated
@ -40,0 +106,4 @@
return fmt.Errorf("invalid bearer token public key: %w", err)
}
if err = frostfsID.ValidatePublicKey(pk); err != nil {
alexvanin commented 2023-11-22 11:52:20 +00:00
Owner
Copy link

Would you like to cache result for some period of time now or later after performance tests?
I think we are going to DOS local neo-go node under heavy load from single s3 client easily.

Would you like to cache result for some period of time now or later after performance tests? I think we are going to DOS local neo-go node under heavy load from single s3 client easily.
👍 1
dkirillov force-pushed feature/260-support_frostfsid from 622ac3da4f to 29e768e297 2023-11-23 08:01:10 +00:00 Compare
alexvanin approved these changes 2023-11-27 08:53:36 +00:00
cmd/s3-gw/app.go Outdated
@ -323,0 +355,4 @@
}
func (s *appSettings) setDefaultNamespaces(namespaces []string) {
for i := range namespaces { // to be set namespaces in evn variable as `S3_GW_KLUDGE_DEFAULT_NAMESPACES="" "root"`
alexvanin commented 2023-11-27 08:52:24 +00:00
Owner
Copy link

evn typo

evn typo
👀 1
dkirillov force-pushed feature/260-support_frostfsid from 29e768e297 to ff1ec56d24 2023-11-27 12:30:23 +00:00 Compare
alexvanin merged commit ff1ec56d24 into master 2023-11-27 14:36:42 +00:00
alexvanin deleted branch feature/260-support_frostfsid 2023-11-27 14:37:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#265
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:feature/260-support_frostfsid"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?