feature/258-add_control_api #270

Merged
alexvanin merged 2 commits from dkirillov/frostfs-s3-gw:feature/258-add_control_api into master 2024-09-04 19:51:12 +00:00
Member

close #258

close #258
dkirillov self-assigned this 2023-11-27 14:56:50 +00:00
dkirillov force-pushed feature/258-add_control_api from c15cf71b42 to d19b322ac1 2023-11-27 15:03:07 +00:00 Compare
dkirillov force-pushed feature/258-add_control_api from d19b322ac1 to acb3dcb2da 2023-11-28 06:53:16 +00:00 Compare
dkirillov force-pushed feature/258-add_control_api from acb3dcb2da to 386909df7f 2023-11-28 08:52:18 +00:00 Compare
dkirillov changed title from WIP: feature/258-add_control_api to feature/258-add_control_api 2023-11-28 08:52:59 +00:00
dkirillov requested review from storage-services-committers 2023-11-28 08:55:38 +00:00
dkirillov requested review from storage-services-developers 2023-11-28 08:55:38 +00:00
mbiryukova reviewed 2023-11-28 13:59:27 +00:00
@ -0,0 +41,4 @@
Signature signature = 2;
}
// Health check request.
Member

response?

response?
mbiryukova marked this conversation as resolved
dkirillov force-pushed feature/258-add_control_api from 386909df7f to ae92aac0ae 2023-11-29 06:32:23 +00:00 Compare
dkirillov force-pushed feature/258-add_control_api from ae92aac0ae to e6944f23fd 2023-11-29 06:33:10 +00:00 Compare
dkirillov force-pushed feature/258-add_control_api from e6944f23fd to caaf235b96 2023-12-01 11:18:06 +00:00 Compare
alexvanin reviewed 2023-12-01 12:01:14 +00:00
@ -0,0 +275,4 @@
return fmt.Errorf("marshal request body: %w", err)
}
// TODO(@cthulhu-rider): #468 use Signature message from FrostFS API to avoid conversion
Owner
Same as https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/pulls/270/files#issuecomment-27785
alexvanin marked this conversation as resolved
@ -0,0 +307,4 @@
return fmt.Errorf("calculate signature: %w", err)
}
// TODO(@cthulhu-rider): #468 use Signature message from FrostFS API to avoid conversion
Owner

I am not sure this todo is valid for service app control APIs.

I am not sure this todo is valid for service app control APIs.
alexvanin marked this conversation as resolved
@ -0,0 +121,4 @@
Signature signature = 2;
}
// Add policy request.
Owner

Remove policy request.

Remove policy request.
alexvanin marked this conversation as resolved
Owner

We've discussed with @dkirillov changes in proto definition to support multiple namespaces in single put and remove operations. Also remove add operation.

We've discussed with @dkirillov changes in proto definition to support multiple namespaces in single put and remove operations. Also remove add operation.
dkirillov force-pushed feature/258-add_control_api from caaf235b96 to 338be97c67 2023-12-01 12:33:35 +00:00 Compare
dkirillov force-pushed feature/258-add_control_api from 338be97c67 to 42862fd69e 2023-12-01 12:47:26 +00:00 Compare
alexvanin approved these changes 2023-12-04 09:28:20 +00:00
alexvanin merged commit 42862fd69e into master 2023-12-04 09:28:58 +00:00
alexvanin deleted branch feature/258-add_control_api 2023-12-04 09:28:59 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-services-developers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#270
No description provided.