TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 6 Projects Releases 18 Packages Activity Actions

[#283] Support group conditions #283

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:feature/support_check_request_by_user_group into master 2024-09-04 19:51:13 +00:00
Conversation 0 Commits 1 Files changed 5 +25 -25
dkirillov commented 2023-12-20 11:43:47 +00:00
Member
Copy link

blocked by TrueCloudLab/policy-engine#38

blocked by https://git.frostfs.info/TrueCloudLab/policy-engine/pulls/38
dkirillov self-assigned this 2023-12-20 11:43:51 +00:00
dkirillov changed title from WIP: [#XX] Test group to WIP: [#283] Test group 2023-12-20 11:43:56 +00:00
dkirillov force-pushed feature/support_check_request_by_user_group from e8317bc431 to 3031e0bb5c 2023-12-20 12:07:59 +00:00 Compare
dkirillov force-pushed feature/support_check_request_by_user_group from 3031e0bb5c to 10c0de85a9 2023-12-20 13:50:19 +00:00 Compare
dkirillov force-pushed feature/support_check_request_by_user_group from 10c0de85a9 to 7db745a106 2023-12-21 11:22:05 +00:00 Compare
dkirillov changed title from WIP: [#283] Test group to [#283] Test group 2023-12-21 11:27:09 +00:00
dkirillov requested review from storage-services-committers 2023-12-21 11:27:14 +00:00
dkirillov requested review from storage-services-developers 2023-12-21 11:27:15 +00:00
alexvanin approved these changes 2023-12-21 13:06:42 +00:00
docs/configuration.md
@ -640,2 +640,3 @@
enabled: false
contract: frostfsid.frostfs
validation:
enabled: false
alexvanin commented 2023-12-21 12:09:29 +00:00
Owner
Copy link

@ironbee FYI: we've changed default here, so by default validation is going to be disabled, so you don't have to change config for local deployment.

@ironbee FYI: we've changed default here, so by default validation is going to be disabled, so you don't have to change config for local deployment.
pkg/service/control/server/server.go Outdated
@ -186,3 +186,3 @@
func (s *Server) GetPolicy(_ context.Context, req *control.GetPolicyRequest) (*control.GetPolicyResponse, error) {
s.log.Info(logs.ControlAPIGetPolicy, zap.String("namespace", req.GetBody().GetNamespace()),
zap.String("chainId", req.GetBody().GetChainID()), zap.String("key", hex.EncodeToString(req.Signature.Key)))
zap.String("chainId", string(req.GetBody().GetChainID())), zap.String("key", hex.EncodeToString(req.Signature.Key)))
alexvanin commented 2023-12-21 12:12:50 +00:00
Owner
Copy link

zap sanitizes strings and I wonder how it may print chainId with binary data.

`zap` sanitizes strings and I wonder how it may print `chainId` with binary data.
dkirillov commented 2023-12-21 13:19:26 +00:00
Author
Member
Copy link
2023-12-21T16:18:48.595+0300    info    server/server.go:187    get policy request      {"service": "control API", "namespace": "", "chainId": "s3:��H���\u001ai�ч��h\u0010O���$\t�k�F!�s��N�&'��", "key": "0313b1ac3a8076e155a7e797b24f0b650cccad5941ea59d7cfd51a024a8b2a06bf"}
2023-12-21T16:18:48.595+0300    info    server/server.go:187    get policy request      {"service": "control API", "namespace": "", "chainId": "s3:\u0002\u0000\u0000\u0000\u0000\u0000\u0000\u0000\t�k�F!�s��N�&'��", "key": "0313b1ac3a8076e155a7e797b24f0b650cccad5941ea59d7cfd51a024a8b2a06bf"}
``` 2023-12-21T16:18:48.595+0300 info server/server.go:187 get policy request {"service": "control API", "namespace": "", "chainId": "s3:��H���\u001ai�ч��h\u0010O���$\t�k�F!�s��N�&'��", "key": "0313b1ac3a8076e155a7e797b24f0b650cccad5941ea59d7cfd51a024a8b2a06bf"} 2023-12-21T16:18:48.595+0300 info server/server.go:187 get policy request {"service": "control API", "namespace": "", "chainId": "s3:\u0002\u0000\u0000\u0000\u0000\u0000\u0000\u0000\t�k�F!�s��N�&'��", "key": "0313b1ac3a8076e155a7e797b24f0b650cccad5941ea59d7cfd51a024a8b2a06bf"} ```
dkirillov commented 2023-12-21 13:21:19 +00:00
Author
Member
Copy link

Probably we should drop at all logging this id, or log it as hex.

Probably we should drop at all logging this id, or log it as hex.
mbiryukova approved these changes 2023-12-21 15:07:23 +00:00
dkirillov force-pushed feature/support_check_request_by_user_group from 7db745a106 to 6509639540 2023-12-21 15:07:35 +00:00 Compare
dkirillov changed title from [#283] Test group to [#283] Support group conditions 2023-12-22 06:15:37 +00:00
alexvanin approved these changes 2023-12-22 10:27:02 +00:00
alexvanin merged commit 6509639540 into master 2023-12-22 10:27:07 +00:00
alexvanin deleted branch feature/support_check_request_by_user_group 2023-12-22 10:27:07 +00:00
alexvanin added this to the v0.29.0 milestone 2024-05-27 09:57:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
mbiryukova
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.29.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#283
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:feature/support_check_request_by_user_group"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?