TrueCloudLab/frostfs-s3-gw
14
2
Fork 17
Code Issues 18 Pull requests 2 Projects Releases 16 Packages Activity Actions

feature/support_proxy_for_contracts #287

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:feature/support_proxy_for_contracts into master 2024-09-04 19:51:13 +00:00
Conversation 0 Commits 1 Files changed 7 +71 -8
dkirillov commented 2023-12-21 14:57:51 +00:00
Member
Copy link
No description provided.
dkirillov self-assigned this 2023-12-21 14:57:51 +00:00
dkirillov force-pushed feature/support_proxy_for_contracts from b33ac9b8a4 to a4d4b7a95f 2023-12-21 14:59:34 +00:00 Compare
dkirillov force-pushed feature/support_proxy_for_contracts from a4d4b7a95f to 949355a187 2023-12-22 06:55:46 +00:00 Compare
dkirillov changed title from WIP: feature/support_proxy_for_contracts to feature/support_proxy_for_contracts 2023-12-22 06:55:59 +00:00
dkirillov requested review from storage-services-committers 2023-12-22 06:56:25 +00:00
dkirillov requested review from storage-services-developers 2023-12-22 06:56:28 +00:00
mbiryukova reviewed 2023-12-22 10:57:32 +00:00
cmd/s3-gw/app_settings.go Outdated
@ -213,6 +213,9 @@ const ( // Settings.
cfgPolicyEnabled = "policy.enabled"
cfgPolicyContract = "policy.contract"
// Proy.
mbiryukova commented 2023-12-22 10:48:59 +00:00
Member
Copy link

typo

typo
mbiryukova marked this conversation as resolved
config/config.env Outdated
@ -206,1 +206,4 @@
# Proxy contract configuration. To enable this functionality the `rpc_endpoint` param must be also set.
# Proxy contract hash (LE) or name in NNS.
S3_GW_POLICY_CONTRACT=proxy.frostfs
mbiryukova commented 2023-12-22 10:56:36 +00:00
Member
Copy link

POLICY -> PROXY

`POLICY` -> `PROXY`
👀 1
mbiryukova marked this conversation as resolved
docs/configuration.md Outdated
@ -664,0 +667,4 @@
Proxy contract configuration. To enable this functionality the `rpc_endpoint` param must be also set.
```yaml
policy:
mbiryukova commented 2023-12-22 10:57:02 +00:00
Member
Copy link

policy -> proxy

`policy` -> `proxy`
mbiryukova marked this conversation as resolved
internal/frostfs/policy/contract/contract.go Outdated
@ -28,6 +30,9 @@ type Config struct {
// Contract is hash of contract or its name in NNS.
Contract string
// ProxyContract is hash of proxy contract or its name in NNS to interact with frostfsid.
mbiryukova commented 2023-12-22 10:57:24 +00:00
Member
Copy link

frostfsid -> policy

`frostfsid` -> `policy`
mbiryukova marked this conversation as resolved
dkirillov force-pushed feature/support_proxy_for_contracts from 949355a187 to 899213b3f3 2023-12-22 12:45:24 +00:00 Compare
mbiryukova approved these changes 2023-12-22 12:56:53 +00:00
alexvanin approved these changes 2023-12-22 13:21:39 +00:00
alexvanin merged commit 899213b3f3 into master 2023-12-22 13:21:45 +00:00
alexvanin deleted branch feature/support_proxy_for_contracts 2023-12-22 13:21:45 +00:00
alexvanin added this to the v0.29.0 milestone 2024-05-27 10:28:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
mbiryukova
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.29.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#287
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:feature/support_proxy_for_contracts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?