[#292] authmate: Support custom attributes #293

dkirillov · 2024-01-19T07:01:02Z

dkirillov commented

2024-01-19 07:01:02 +00:00

close #292

dkirillov self-assigned this 2024-01-19 07:01:03 +00:00

dkirillov changed title from ~~WIP: [#XX] authmate: Support custom attributes~~ to WIP: [#292] authmate: Support custom attributes

2024-01-19 07:09:17 +00:00

dkirillov force-pushed feature/support_custom_attributes_in_authmate from d2d40ec322 to 05ced675e4

2024-01-19 07:54:54 +00:00

Compare

dkirillov changed title from ~~WIP: [#292] authmate: Support custom attributes~~ to [#292] authmate: Support custom attributes

2024-01-19 07:55:45 +00:00

dkirillov requested review from storage-services-developers 2024-01-19 07:55:52 +00:00

dkirillov requested review from storage-services-committers 2024-01-19 07:55:54 +00:00

alexvanin approved these changes 2024-01-19 11:20:06 +00:00

cmd/s3-authmate/modules/update-secret.go Outdated

					
				@ -44,6 +44,7 @@ func initUpdateSecretCmd() {

					updateSecretCmd.Flags().String(frostfsIDProxyFlag, "", "Proxy contract hash (LE) or name in NNS to use when interact with frostfsid contract")

					updateSecretCmd.Flags().String(frostfsIDNamespaceFlag, "", "Namespace to register public key in frostfsid contract")

					updateSecretCmd.Flags().String(rpcEndpointFlag, "", "NEO node RPC address")

					updateSecretCmd.Flags().String(attributesFlag, "", "User attributes in form of Key1=Value1,Key2=Value2 (note: you cannot override system attributes)")

alexvanin commented

2024-01-19 11:19:50 +00:00

In the future, I suggest to use different approach to handle slice of strings, by using Flags().StringArray(). I think it's better to pass multiple values by repeating flag and avoid splitting by symbol.

command --flag "element0" --flag "element1" --flag "element2"

In this PR it makes sense to keep compatibility with attributes of frostfs-cli command.

In the future, I suggest to use different approach to handle slice of strings, by using `Flags().StringArray()`. I think it's better to pass multiple values by repeating flag and avoid splitting by symbol. ``` command --flag "element0" --flag "element1" --flag "element2" ``` In this PR it makes sense to keep compatibility with attributes of frostfs-cli command.

mbiryukova approved these changes 2024-01-19 14:54:10 +00:00

creds/tokens/credentials.go Outdated

					
				@ -51,2 +60,4 @@

					// Object payload.

					Payload []byte

					// CustomAttributes are additional user provided attributes for bog object.