feature/165-speed_up_listing #294
No reviewers
TrueCloudLab/storage-services-developers
Labels
No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-s3-gw#294
Loading…
Reference in a new issue
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:feature/165-speed_up_listing"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
close #165
c0298b167e
toda1a5800c3
WIP: feature/165-speed_up_listingto feature/165-speed_up_listing4ffde07ac5
to6e73d64b37
6e73d64b37
toa74d498df2
Looks good, we've done some tests in loaded environments and it works pretty good. Let's see how compatibility tests are doing after merge.
@ -722,3 +714,1 @@
}
n.cache.DeleteObjectName(bkt.CID, bkt.Name, obj.Name)
if !client.IsErrObjectAlreadyRemoved(obj.Error) && !client.IsErrObjectNotFound(obj.Error) {
I will create an issue to investigate if we should improve this code and ignore more different errors here, including gRPC (network) errors. This is not quite clear for me right now.
@ -146,6 +147,7 @@ func (t *memoryTree) createPathIfNotExist(parent *treeNodeMemory, path []string)
}
t.idCounter++
parent.children = append(parent.children, node)
//sortNodes(parent.children)
Seems don't need it.
Fixed
c334adeb6d
@ -326,6 +375,7 @@ func (c *ServiceClientMemory) AddNodeByPath(_ context.Context, bktInfo *data.Buc
}
parentNode.children = append(parentNode.children, tn)
//sortNodes(parentNode.children)
Seems don't need it.
@ -356,11 +406,38 @@ func (c *ServiceClientMemory) MoveNode(_ context.Context, bktInfo *data.BucketIn
node.data.parentID = parentID
newParent.children = append(newParent.children, node)
//sortNodes(newParent.children)
Seems don't need it.