TrueCloudLab
/
frostfs-s3-gw
16
2
Fork 14
Code Issues 19 Pull Requests 4 Actions Packages Releases 6 Activity

feature/165-speed_up_listing #294

Merged
alexvanin merged 22 commits from dkirillov/frostfs-s3-gw:feature/165-speed_up_listing into master 2024-02-02 14:04:06 +00:00
Conversation 0 Commits 22 Files Changed 32
dkirillov commented 2024-01-22 12:26:20 +00:00
Collaborator

close #165

close #165
dkirillov self-assigned this 2024-01-22 12:26:21 +00:00
dkirillov force-pushed feature/165-speed_up_listing from c0298b167e to da1a5800c3 2024-01-25 06:39:26 +00:00 Compare
dkirillov changed title from WIP: feature/165-speed_up_listing to feature/165-speed_up_listing 2024-01-25 06:45:24 +00:00
dkirillov requested review from storage-services-committers 2024-01-29 07:53:00 +00:00
dkirillov requested review from storage-services-developers 2024-01-29 07:53:01 +00:00
dkirillov force-pushed feature/165-speed_up_listing from 4ffde07ac5 to 6e73d64b37 2024-02-02 13:13:39 +00:00 Compare
dkirillov force-pushed feature/165-speed_up_listing from 6e73d64b37 to a74d498df2 2024-02-02 13:15:25 +00:00 Compare
alexvanin approved these changes 2024-02-02 13:31:22 +00:00
alexvanin left a comment
Owner

Looks good, we've done some tests in loaded environments and it works pretty good. Let's see how compatibility tests are doing after merge.

Looks good, we've done some tests in loaded environments and it works pretty good. Let's see how compatibility tests are doing after merge.
api/layer/layer.go Outdated
@ -722,3 +714,1 @@
}
n.cache.DeleteObjectName(bkt.CID, bkt.Name, obj.Name)
if !client.IsErrObjectAlreadyRemoved(obj.Error) && !client.IsErrObjectNotFound(obj.Error) {
alexvanin commented 2024-02-02 12:45:04 +00:00
Owner

I will create an issue to investigate if we should improve this code and ignore more different errors here, including gRPC (network) errors. This is not quite clear for me right now.

I will create an issue to investigate if we should improve this code and ignore more different errors here, including gRPC (network) errors. This is not quite clear for me right now.
pkg/service/tree/tree_client_in_memory.go Outdated
@ -146,6 +147,7 @@ func (t *memoryTree) createPathIfNotExist(parent *treeNodeMemory, path []string)
}
t.idCounter++
parent.children = append(parent.children, node)
//sortNodes(parent.children)
alexvanin commented 2024-02-02 13:11:05 +00:00
Owner

Seems don't need it.

Seems don't need it.
dkirillov commented 2024-02-02 13:54:05 +00:00
Poster
Collaborator

Fixed c334adeb6d

Fixed https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/commit/c334adeb6da0bf6fa889b1bf8bb370ccc80f2b0e
alexvanin marked this conversation as resolved
pkg/service/tree/tree_client_in_memory.go Outdated
@ -326,6 +375,7 @@ func (c *ServiceClientMemory) AddNodeByPath(_ context.Context, bktInfo *data.Buc
}
parentNode.children = append(parentNode.children, tn)
//sortNodes(parentNode.children)
alexvanin commented 2024-02-02 13:10:46 +00:00
Owner

Seems don't need it.

Seems don't need it.
alexvanin marked this conversation as resolved
pkg/service/tree/tree_client_in_memory.go Outdated
@ -356,11 +406,38 @@ func (c *ServiceClientMemory) MoveNode(_ context.Context, bktInfo *data.BucketIn
node.data.parentID = parentID
newParent.children = append(newParent.children, node)
//sortNodes(newParent.children)
alexvanin commented 2024-02-02 13:10:41 +00:00
Owner

Seems don't need it.

Seems don't need it.
alexvanin marked this conversation as resolved
dkirillov added 1 commit 2024-02-02 13:53:24 +00:00
/ DCO (pull_request) Successful in 1m22s Details
/ Builds (1.20) (pull_request) Successful in 1m52s Details
/ Builds (1.21) (pull_request) Successful in 1m17s Details
/ Vulncheck (pull_request) Successful in 1m51s Details
/ Lint (pull_request) Failing after 1m55s Details
/ Tests (1.20) (pull_request) Successful in 2m24s Details
/ Tests (1.21) (pull_request) Successful in 2m24s Details
c334adeb6d [#165] Sort nodes in ServiceClientMemory 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
alexvanin merged commit c334adeb6d into master 2024-02-02 14:04:06 +00:00
alexvanin deleted branch feature/165-speed_up_listing 2024-02-02 14:04:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dkirillov
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#294
There is no content yet.
Delete Branch "dkirillov/frostfs-s3-gw:feature/165-speed_up_listing"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?