TrueCloudLab/frostfs-s3-gw
18
3
Fork 20
Code Issues 29 Pull requests 8 Projects Releases 23 Packages Activity Actions

[#339] Support SigV4A #344

Merged
alexvanin merged 11 commits from dkirillov/frostfs-s3-gw:feature/339-sigv4a_support into master 2024-12-10 14:34:08 +00:00
Conversation 0 Commits 11 Files changed 55 +5120 -1260
dkirillov commented 2024-03-28 07:58:29 +00:00
Member
Copy link

close #339

close #339
dkirillov self-assigned this 2024-03-28 07:58:29 +00:00
dkirillov force-pushed feature/339-sigv4a_support from 117725eb67 to 978679f380 2024-04-23 11:49:45 +00:00 Compare
dkirillov force-pushed feature/339-sigv4a_support from 978679f380 to 65b1a25f90 2024-09-05 12:47:19 +00:00 Compare
dkirillov changed title from WIP: [#339] tmp to WIP: [#339] Support SigV4A 2024-09-05 12:47:49 +00:00
dkirillov force-pushed feature/339-sigv4a_support from 65b1a25f90 to 85a81d2f79 2024-09-05 12:48:45 +00:00 Compare
dkirillov requested review from storage-services-committers 2024-09-05 12:49:04 +00:00
dkirillov requested review from storage-services-developers 2024-09-05 12:49:05 +00:00
dkirillov changed title from WIP: [#339] Support SigV4A to [#339] Support SigV4A 2024-09-05 12:49:12 +00:00
alexvanin added this to the v0.32.0 milestone 2024-09-16 13:10:04 +00:00
dkirillov force-pushed feature/339-sigv4a_support from 85a81d2f79 to 58b193c8d9 2024-11-26 14:51:05 +00:00 Compare
dkirillov added 1 commit 2024-11-27 08:32:16 +00:00
[#339] Fix logging in authmate [pre]sign command
All checks were successful
/ DCO (pull_request) Successful in 1m50s
Details
/ Vulncheck (pull_request) Successful in 1m59s
Details
/ Builds (pull_request) Successful in 1m58s
Details
/ Lint (pull_request) Successful in 3m5s
Details
/ Tests (pull_request) Successful in 1m59s
Details
09ffe7287a 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
alexvanin reviewed 2024-11-27 15:35:32 +00:00
api/auth/presign_test.go Outdated
@ -15,1 +19,3 @@
"github.com/aws/aws-sdk-go/aws/credentials"
"github.com/aws/aws-sdk-go-v2/aws"
credentialsv2 "github.com/aws/aws-sdk-go-v2/credentials"
"github.com/aws/smithy-go/logging"
alexvanin commented 2024-11-27 15:35:32 +00:00
Owner
Copy link

What you think about modifying v4a code a bit to get rid of this logger?

What you think about modifying v4a code a bit to get rid of this logger?
dkirillov commented 2024-11-28 13:27:19 +00:00
Author
Member
Copy link

I have no strong opinion on this matter.

I have no strong opinion on this matter.
alexvanin commented 2024-12-04 12:05:50 +00:00
Owner
Copy link

I suggest you to try to remove all smithy-go imports from the code, if it is possible. To me it looks like completely redundant library for us.

I suggest you to try to remove all `smithy-go` imports from the code, if it is possible. To me it looks like completely redundant library for us.
dkirillov added 1 commit 2024-11-28 09:37:16 +00:00
[#339] Drop unused and add link to source files
All checks were successful
/ DCO (pull_request) Successful in 2m23s
Details
/ Vulncheck (pull_request) Successful in 2m29s
Details
/ Builds (pull_request) Successful in 1m36s
Details
/ Lint (pull_request) Successful in 2m23s
Details
/ Tests (pull_request) Successful in 1m52s
Details
d7a1cfe6a3 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
alexvanin modified the milestone from v0.32.0 to v0.31.1 2024-12-03 14:43:33 +00:00
alexvanin modified the milestone from v0.31.1 to v0.32.0 2024-12-03 15:18:26 +00:00
dkirillov force-pushed feature/339-sigv4a_support from d7a1cfe6a3 to b8abf01bfa 2024-12-04 13:11:38 +00:00 Compare
dkirillov added 1 commit 2024-12-04 14:44:05 +00:00
[#339] Fix stream sigV4a chunk-encoding
All checks were successful
/ DCO (pull_request) Successful in 2m5s
Details
/ Vulncheck (pull_request) Successful in 2m10s
Details
/ Builds (pull_request) Successful in 1m28s
Details
/ Lint (pull_request) Successful in 2m48s
Details
/ Tests (pull_request) Successful in 1m57s
Details
a9633fee18 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
nzinkevich reviewed 2024-12-09 08:20:12 +00:00
api/auth/center.go Outdated
@ -344,1 +401,4 @@
creds := aws.Credentials{
AccessKeyID: authHeader.AccessKeyID,
SecretAccessKey: box.Gate.SecretKey,
}
nzinkevich commented 2024-12-09 07:44:03 +00:00
Member
Copy link

nitpick: consider rewriting in one line or use credentials.NewStaticCredentialsProvider

nitpick: consider rewriting in one line or use `credentials.NewStaticCredentialsProvider`
dkirillov force-pushed feature/339-sigv4a_support from a9633fee18 to 9395b5f39d 2024-12-10 12:06:21 +00:00 Compare
alexvanin approved these changes 2024-12-10 14:33:52 +00:00
alexvanin left a comment
Owner
Copy link

Looks good, let's see how it going to work with S3 clients before gateway release.

Looks good, let's see how it going to work with S3 clients before gateway release.
alexvanin merged commit 9395b5f39d into master 2024-12-10 14:34:08 +00:00
alexvanin deleted branch feature/339-sigv4a_support 2024-12-10 14:34:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.32.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#344
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:feature/339-sigv4a_support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?