TrueCloudLab/frostfs-s3-gw
18
3
Fork 20
Code Issues 29 Pull requests 8 Projects Releases 23 Packages Activity Actions

[#367] Add check of AccessBox attributes #367

Merged
alexvanin merged 1 commit from mbiryukova/frostfs-s3-gw:feature/check_accessbox_attrs into master 2024-04-19 06:25:27 +00:00
Conversation 0 Commits 1 Files changed 22 +157 -110
mbiryukova commented 2024-04-16 08:49:09 +00:00
Member
Copy link

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2024-04-16 08:49:09 +00:00
mbiryukova force-pushed feature/check_accessbox_attrs from 6496dc760d to 6a76dd222a 2024-04-16 08:49:45 +00:00 Compare
mbiryukova changed title from [#xxx] Add check of AccessBox attributes to [#367] Add check of AccessBox attributes 2024-04-16 08:53:48 +00:00
mbiryukova requested review from storage-services-committers 2024-04-16 08:56:54 +00:00
mbiryukova requested review from storage-services-developers 2024-04-16 08:56:54 +00:00
dkirillov reviewed 2024-04-16 09:21:20 +00:00
api/middleware/auth.go Outdated
@ -70,6 +72,7 @@ func Auth(center Center, log *zap.Logger) Func {
ctx = SetClientTime(ctx, box.ClientTime)
}
ctx = SetAuthHeaders(ctx, box.AuthHeaders)
ctx = SetAccessBoxAttrs(ctx, box.Attributes)
dkirillov commented 2024-04-16 09:13:12 +00:00
Member
Copy link

Can we set whole box rather than each field separately?

Can we set whole `box` rather than each field separately?
dkirillov marked this conversation as resolved
api/middleware/policy.go Outdated
@ -405,0 +405,4 @@
attrs, err := GetAccessBoxAttrs(ctx)
if err == nil {
for _, attr := range attrs {
res[fmt.Sprintf(s3.PropertyKeyFormatAccessBoxAttr, attr.Key())] = attr.Value()
dkirillov commented 2024-04-16 09:21:12 +00:00
Member
Copy link

It would be nice to add tests for that properties

It would be nice to add tests for that properties
👍 1
dkirillov marked this conversation as resolved
go.mod Outdated
@ -35,6 +35,8 @@ require (
google.golang.org/protobuf v1.33.0
)
replace git.frostfs.info/TrueCloudLab/policy-engine v0.0.0-20240412102212-530248de754c => git.frostfs.info/mbiryukova/policy-engine v0.0.0-20240416071728-04a79f57ef1f
dkirillov commented 2024-04-16 09:09:55 +00:00
Member
Copy link

I suppose this means that we are blocked by TrueCloudLab/policy-engine#70

I suppose this means that we are blocked by https://git.frostfs.info/TrueCloudLab/policy-engine/pulls/70
dkirillov commented 2024-04-17 06:45:56 +00:00
Member
Copy link

Now we can use appropriate dependency

Now we can use appropriate dependency
👍 1
dkirillov marked this conversation as resolved
internal/frostfs/authmate.go Outdated
@ -93,3 +94,1 @@
defer res.Payload.Close()
return io.ReadAll(res.Payload)
return res.Head.Payload(), res.Head.Attributes(), err
dkirillov commented 2024-04-16 09:19:22 +00:00
Member
Copy link

Probably we can return res.Head

Probably we can return `res.Head`
dkirillov marked this conversation as resolved
mbiryukova force-pushed feature/check_accessbox_attrs from 6a76dd222a to a82f7dbacb 2024-04-16 12:26:21 +00:00 Compare
mbiryukova force-pushed feature/check_accessbox_attrs from a82f7dbacb to b48d78d259 2024-04-16 12:36:31 +00:00 Compare
dkirillov approved these changes 2024-04-17 06:50:30 +00:00
dkirillov left a comment
Member
Copy link

LGTM, (see last comment)

LGTM, (see last comment)
mbiryukova force-pushed feature/check_accessbox_attrs from b48d78d259 to 22d0c7e5e6 2024-04-17 07:29:46 +00:00 Compare
mbiryukova force-pushed feature/check_accessbox_attrs from 22d0c7e5e6 to b279bdffe4 2024-04-17 09:29:21 +00:00 Compare
dkirillov approved these changes 2024-04-17 09:36:22 +00:00
alexvanin added this to the v0.30.0 milestone 2024-04-18 06:41:45 +00:00
alexvanin approved these changes 2024-04-19 06:25:21 +00:00
alexvanin merged commit e22ff52165 into master 2024-04-19 06:25:27 +00:00
alexvanin deleted branch feature/check_accessbox_attrs 2024-04-19 06:25:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.30.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#367
No description provided.
Delete branch "mbiryukova/frostfs-s3-gw:feature/check_accessbox_attrs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?