TrueCloudLab/frostfs-s3-gw
15
2
Fork 17
Code Issues 22 Pull requests 5 Projects Releases 15 Packages Activity Actions

[#371] Add custom Source IP header configuration #371

Merged
dkirillov merged 1 commit from mbiryukova/frostfs-s3-gw:feature/source_ip_header into master 2024-04-22 07:42:47 +00:00
Conversation 1 Commits 1 Files changed 11 +54 -13
mbiryukova commented 2024-04-17 14:14:37 +00:00
Member
Copy link

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2024-04-17 14:14:38 +00:00
mbiryukova force-pushed feature/source_ip_header from ab1bebdb78 to b58add4957 2024-04-17 14:15:17 +00:00 Compare
mbiryukova changed title from [#xxx] Add custom Source IP header configuration to [#371] Add custom Source IP header configuration 2024-04-17 14:15:43 +00:00
mbiryukova requested review from storage-services-committers 2024-04-17 14:21:30 +00:00
mbiryukova requested review from storage-services-developers 2024-04-17 14:21:30 +00:00
alexvanin added this to the v0.30.0 milestone 2024-04-18 06:41:34 +00:00
dkirillov approved these changes 2024-04-18 09:03:37 +00:00
docs/configuration.md Outdated
@ -236,6 +238,7 @@ reconnect_interval: 1m
| `max_clients_deadline` | `duration` | no | `30s` | Deadline after which the gate sends error `RequestTimeout` to a client. |
| `allowed_access_key_id_prefixes` | `[]string` | no | | List of allowed `AccessKeyID` prefixes which S3 GW serve. If the parameter is omitted, all `AccessKeyID` will be accepted. |
| `reconnect_interval` | `duration` | no | `1m` | Listeners reconnection interval. |
| `source_ip_header` | `string` | yes | | Custom header to retrieve Source IP. |
dkirillov commented 2024-04-18 08:59:22 +00:00
Member
Copy link

Please, mention this param in changelog

Please, mention this param in changelog
👀 1
dkirillov marked this conversation as resolved
mbiryukova force-pushed feature/source_ip_header from b58add4957 to e2f0799284 2024-04-18 10:31:12 +00:00 Compare
dkirillov approved these changes 2024-04-18 11:18:23 +00:00
dkirillov commented 2024-04-19 09:25:03 +00:00
Member
Copy link

Please, rebase

Please, rebase
mbiryukova force-pushed feature/source_ip_header from e2f0799284 to e3f03f4599 2024-04-19 09:29:32 +00:00 Compare
dkirillov approved these changes 2024-04-19 11:08:43 +00:00
pogpp approved these changes 2024-04-22 07:41:53 +00:00
dkirillov merged commit 45f77de8c8 into master 2024-04-22 07:42:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
pogpp
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.30.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#371
No description provided.
Delete branch "mbiryukova/frostfs-s3-gw:feature/source_ip_header"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?