TrueCloudLab/frostfs-s3-gw
15
3
Fork 18
Code Issues 28 Pull requests 5 Projects Releases 17 Packages Activity Actions

[#382] Fix request type determination #382

Merged
alexvanin merged 1 commit from mbiryukova/frostfs-s3-gw:bugfix/determine_req_type into master 2024-05-07 12:34:01 +00:00
Conversation 0 Commits 1 Files changed 2 +84 -2
mbiryukova commented 2024-05-06 10:16:58 +00:00
Member
Copy link

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2024-05-06 10:16:58 +00:00
mbiryukova force-pushed bugfix/determine_req_type from 2a6a6d45c5 to 3816770d54 2024-05-06 10:17:40 +00:00 Compare
mbiryukova changed title from [#xxx] Fix request type determination to [#382] Fix request type determination 2024-05-06 10:18:10 +00:00
mbiryukova requested review from storage-services-committers 2024-05-06 10:24:15 +00:00
mbiryukova requested review from storage-services-developers 2024-05-06 10:24:16 +00:00
mbiryukova force-pushed bugfix/determine_req_type from 3816770d54 to bbd61a7f6c 2024-05-06 11:39:05 +00:00 Compare
dkirillov approved these changes 2024-05-06 14:39:09 +00:00
api/middleware/policy_test.go Outdated
@ -0,0 +47,4 @@
reqType, bktName, objName = getBucketObject(r, []string{"some-domain", domain})
require.Equal(t, objectType, reqType)
require.Equal(t, bkt, bktName)
require.Equal(t, obj, objName)
dkirillov commented 2024-05-06 14:39:05 +00:00
Member
Copy link

Probably, it would be convenient to use table tests. But it's up to you

Probably, it would be convenient to use table tests. But it's up to you
dkirillov marked this conversation as resolved
mbiryukova force-pushed bugfix/determine_req_type from bbd61a7f6c to a92c88ec36 2024-05-06 18:24:56 +00:00 Compare
dkirillov approved these changes 2024-05-07 06:46:21 +00:00
r.loginov approved these changes 2024-05-07 11:14:08 +00:00
mbiryukova force-pushed bugfix/determine_req_type from a92c88ec36 to c43ef040dc 2024-05-07 12:18:18 +00:00 Compare
alexvanin merged commit c43ef040dc into master 2024-05-07 12:34:01 +00:00
alexvanin deleted branch bugfix/determine_req_type 2024-05-07 12:34:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
r.loginov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#382
No description provided.
Delete branch "mbiryukova/frostfs-s3-gw:bugfix/determine_req_type"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?