TrueCloudLab
/
frostfs-s3-gw
16
2
Fork 14
Code Issues 19 Pull Requests 5 Actions Packages Releases 7 Activity

[#335] Improve determining AccessBox latest version #391

Merged
alexvanin merged 1 commits from Anoke/frostfs-s3-gw:improve-determing-latest-version-accessbox into master 2024-06-06 12:35:52 +00:00
Conversation 1 Commits 1 Files Changed 3
Anoke commented 2024-05-24 18:42:08 +00:00

As it was asked used S3-CRDT-Versions-Add header to know if one version is older than other, for this I modified function less to sort objectVersion correctly

As it was asked used S3-CRDT-Versions-Add header to know if one version is older than other, for this I modified function less to sort objectVersion correctly
Anoke added 1 commit 2024-05-24 18:42:34 +00:00
/ Vulncheck (pull_request) Has been cancelled Details
/ Builds (1.20) (pull_request) Has been cancelled Details
/ Builds (1.21) (pull_request) Has been cancelled Details
/ DCO (pull_request) Has been cancelled Details
/ Lint (pull_request) Has been cancelled Details
/ Tests (1.20) (pull_request) Has been cancelled Details
/ Tests (1.21) (pull_request) Has been cancelled Details
ced2062f5c [#335]Improve determining AccessBox latest version 
Signed-off-by: Anoke <rustamgta1011@gmail.com>
dkirillov reviewed 2024-05-27 06:32:42 +00:00
internal/frostfs/crdt/gset.go Outdated
@ -108,6 +108,12 @@ func (v *ObjectVersions) getAddHeader() string {
}
func less(ov1, ov2 *ObjectVersion) bool {
if contains(splitVersions(ov1.Headers[versionsAddAttr]), ov2.VersionID()) {
dkirillov commented 2024-05-27 06:32:42 +00:00
Collaborator

It seems we can use just

strings.Contains(ov1.Headers[versionsAddAttr], ov2.VersionID())
It seems we can use just ```golang strings.Contains(ov1.Headers[versionsAddAttr], ov2.VersionID()) ```
👍 1
dkirillov marked this conversation as resolved
dkirillov requested review from storage-services-committers 2024-05-27 06:33:36 +00:00
dkirillov requested review from storage-services-developers 2024-05-27 06:33:38 +00:00
dkirillov reviewed 2024-05-27 06:45:23 +00:00
internal/frostfs/crdt/gset.go
@ -111,2 +115,4 @@
return true
}
if ov1.CreationEpoch == ov2.CreationEpoch {
return ov1.VersionID() < ov2.VersionID()
dkirillov commented 2024-05-27 06:45:23 +00:00
Collaborator

On this line we will compute VersionIDs, that have already been computed above (line 111, 114). So probably we can compute this just one in the beginning of the function:

func less(ov1, ov2 *ObjectVersion) bool {
    versionID1, versionID2 := ov1.VersionID(), ov2.VersionID()
    // ...
}
On this line we will compute VersionIDs, that have already been computed above (line 111, 114). So probably we can compute this just one in the beginning of the function: ```golang func less(ov1, ov2 *ObjectVersion) bool { versionID1, versionID2 := ov1.VersionID(), ov2.VersionID() // ... } ```
👍 1
dkirillov marked this conversation as resolved
Anoke added 1 commit 2024-05-27 13:27:13 +00:00
/ Lint (pull_request) Has been cancelled Details
/ Tests (1.20) (pull_request) Has been cancelled Details
/ Tests (1.21) (pull_request) Has been cancelled Details
/ Vulncheck (pull_request) Has been cancelled Details
/ Builds (1.20) (pull_request) Has been cancelled Details
/ Builds (1.21) (pull_request) Has been cancelled Details
/ DCO (pull_request) Has been cancelled Details
81b3b213d2 [#335] Improve determining AccessBox latest version 
Signed-off-by: Anoke <rustamgta1011@gmail.com>
Anoke force-pushed improve-determing-latest-version-accessbox from 81b3b213d2 to b98a43e059 2024-05-27 13:33:43 +00:00 Compare
dkirillov approved these changes 2024-05-28 06:18:24 +00:00
alexvanin added this to the v0.30.0 milestone 2024-05-29 12:02:19 +00:00
alexvanin commented 2024-05-29 12:55:13 +00:00
Owner

@Anoke please check linter error. You can run it locally with make lint or see output of CI/CD runner: https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/actions/runs/2643/jobs/0

@Anoke please check linter error. You can run it locally with `make lint` or see output of CI/CD runner: https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/actions/runs/2643/jobs/0
👍 1
Anoke added 1 commit 2024-05-31 08:42:15 +00:00
/ DCO (pull_request) Successful in 1m36s Details
/ Vulncheck (pull_request) Successful in 1m48s Details
/ Builds (1.20) (pull_request) Successful in 2m49s Details
/ Builds (1.21) (pull_request) Successful in 1m30s Details
/ Lint (pull_request) Successful in 4m40s Details
/ Tests (1.20) (pull_request) Successful in 2m49s Details
/ Tests (1.21) (pull_request) Failing after 2m43s Details
373b8552bd [#335] Improve determining AccessBox latest version 
Signed-off-by: Anoke <rustamgta1011@gmail.com>
Anoke force-pushed improve-determing-latest-version-accessbox from 373b8552bd to eb13da1565 2024-05-31 08:45:01 +00:00 Compare
dkirillov approved these changes 2024-05-31 11:13:47 +00:00
pogpp approved these changes 2024-05-31 13:10:39 +00:00
alexvanin merged commit 58850f590e into master 2024-06-06 12:35:52 +00:00
alexvanin deleted branch improve-determing-latest-version-accessbox 2024-06-06 12:36:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
pogpp
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.30.0
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#391
There is no content yet.
Delete Branch "Anoke/frostfs-s3-gw:improve-determing-latest-version-accessbox"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?