TrueCloudLab
/
frostfs-s3-gw
16
2
Fork 14
Code Issues 19 Pull Requests 4 Actions Packages Releases 6 Activity

feature/372-drop_eacl_related_code #397

Merged
alexvanin merged 3 commits from dkirillov/frostfs-s3-gw:feature/372-drop_eacl_related_code into master 2024-07-01 14:18:59 +00:00
Conversation 1 Commits 3 Files Changed 32
dkirillov commented 2024-05-28 13:06:06 +00:00
Collaborator

close #372

close #372
dkirillov self-assigned this 2024-05-28 13:06:06 +00:00
dkirillov added 3 commits 2024-05-28 13:06:12 +00:00
c36288acf6 [#372] Drop kludge.acl_enabled flag 
Now only APE container can be created using s3-gw

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
0217aa0f7a [#372] authmate: Don't create creds with eacl table 
Allow only impersonate flag.
Don't allow SetEACL container session token.

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
/ DCO (pull_request) Successful in 3m50s Details
/ Vulncheck (pull_request) Successful in 3m39s Details
/ Lint (pull_request) Successful in 6m28s Details
/ Tests (1.20) (pull_request) Successful in 3m55s Details
/ Tests (1.21) (pull_request) Successful in 3m48s Details
/ Builds (1.20) (pull_request) Successful in 1m13s Details
/ Builds (1.21) (pull_request) Successful in 4m6s Details
f1ada00b75 [#372] Drop [e]ACL related code 
Always consider buckets as APE compatible

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov requested review from storage-services-committers 2024-05-28 13:16:05 +00:00
dkirillov requested review from storage-services-developers 2024-05-28 13:16:06 +00:00
pogpp approved these changes 2024-05-29 09:14:57 +00:00
alexvanin reviewed 2024-05-29 12:00:35 +00:00
alexvanin left a comment
Owner

Looks awesome. Let's wait for resolution on ACL -> APE transition in next frostfs-storage release and then consider keeping this code or not.

Looks awesome. Let's wait for resolution on ACL -> APE transition in next frostfs-storage release and then consider keeping this code or not.
dkirillov commented 2024-06-04 08:28:44 +00:00
Poster
Collaborator

I suppose we should drop authenticated-read cannedACL

I suppose we should drop `authenticated-read` cannedACL
dkirillov force-pushed feature/372-drop_eacl_related_code from f1ada00b75 to 491959eb01 2024-07-01 13:55:13 +00:00 Compare
dkirillov force-pushed feature/372-drop_eacl_related_code from 491959eb01 to c2060735c6 2024-07-01 13:56:19 +00:00 Compare
dkirillov force-pushed feature/372-drop_eacl_related_code from c2060735c6 to 465eaa816a 2024-07-01 13:59:03 +00:00 Compare
alexvanin approved these changes 2024-07-01 14:17:11 +00:00
alexvanin merged commit 465eaa816a into master 2024-07-01 14:18:58 +00:00
alexvanin deleted branch feature/372-drop_eacl_related_code 2024-07-01 14:19:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pogpp
alexvanin
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dkirillov
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#397
There is no content yet.
Delete Branch "dkirillov/frostfs-s3-gw:feature/372-drop_eacl_related_code"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?