TrueCloudLab/frostfs-s3-gw
15
3
Fork 19
Code Issues 29 Pull requests 6 Projects Releases 17 Packages Activity Actions

[#412] Store creation epoch in tree service #424

Merged
alexvanin merged 1 commit from mbiryukova/frostfs-s3-gw:feature/epoch_timestamps into feature/lifecycle 2024-07-23 12:21:06 +00:00
Conversation 0 Commits 1 Files changed 15 +172 -77
mbiryukova commented 2024-07-12 12:22:33 +00:00
Member
Copy link

Closes #412

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Closes #412 Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2024-07-12 12:22:33 +00:00
mbiryukova added 1 commit 2024-07-12 12:22:37 +00:00
[#412] Store creation epoch in tree service
All checks were successful
/ DCO (pull_request) Successful in 52s
Details
/ Builds (1.20) (pull_request) Successful in 2m38s
Details
/ Builds (1.21) (pull_request) Successful in 2m37s
Details
/ Vulncheck (pull_request) Successful in 2m48s
Details
/ Lint (pull_request) Successful in 4m17s
Details
/ Tests (1.20) (pull_request) Successful in 2m58s
Details
/ Tests (1.21) (pull_request) Successful in 2m45s
Details
5a2a2c2326 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
dkirillov reviewed 2024-07-15 06:37:40 +00:00
api/layer/frostfs.go Outdated
@ -241,2 +240,2 @@
// prevented the container from being created.
CreateObject(context.Context, PrmObjectCreate) (oid.ID, error)
// It returns any error encountered which prevented the object from being created.
CreateObject(context.Context, PrmObjectCreate) (oid.ID, uint64, error)
dkirillov commented 2024-07-15 06:37:28 +00:00
Member
Copy link

Let's compose returned params into struct

Let's compose returned params into struct
dkirillov marked this conversation as resolved
api/layer/object.go Outdated
@ -496,2 +497,2 @@
// Returns object ID and payload sha256 hash.
func (n *Layer) objectPutAndHash(ctx context.Context, prm PrmObjectCreate, bktInfo *data.BucketInfo) (uint64, oid.ID, []byte, []byte, error) {
// Returns object size, ID, payload sha256 and md5 hashes, creation epoch.
func (n *Layer) objectPutAndHash(ctx context.Context, prm PrmObjectCreate, bktInfo *data.BucketInfo) (uint64, oid.ID, []byte, []byte, uint64, error) {
dkirillov commented 2024-07-15 06:36:20 +00:00
Member
Copy link

Too many returned params, let's consider compose them into struct

Too many returned params, let's consider compose them into struct
dkirillov marked this conversation as resolved
mbiryukova force-pushed feature/epoch_timestamps from 5a2a2c2326 to 81820de6d4 2024-07-15 09:57:13 +00:00 Compare
mbiryukova force-pushed feature/epoch_timestamps from 81820de6d4 to a6b8656622 2024-07-15 10:08:15 +00:00 Compare
mbiryukova force-pushed feature/epoch_timestamps from a6b8656622 to 4220436d56 2024-07-22 11:21:30 +00:00 Compare
mbiryukova changed title from WIP: [#412] Store creation epoch in tree service to [#412] Store creation epoch in tree service 2024-07-22 11:30:51 +00:00
mbiryukova requested review from storage-services-committers 2024-07-22 11:31:11 +00:00
mbiryukova requested review from storage-services-developers 2024-07-22 11:31:51 +00:00
dkirillov reviewed 2024-07-22 13:19:40 +00:00
pkg/service/tree/tree.go Outdated
@ -94,6 +94,7 @@ const (
etagKV = "ETag"
md5KV = "MD5"
finishedKV = "Finished"
createdEpochKV = "CreatedEpoch"
dkirillov commented 2024-07-22 13:19:40 +00:00
Member
Copy link

Maybe it's better to use CreationEpoch name?

Maybe it's better to use `CreationEpoch` name?
👀 1
dkirillov marked this conversation as resolved
mbiryukova force-pushed feature/epoch_timestamps from 4220436d56 to a4a4573b10 2024-07-22 14:45:20 +00:00 Compare
dkirillov approved these changes 2024-07-23 06:33:31 +00:00
alexvanin approved these changes 2024-07-23 12:15:07 +00:00
alexvanin merged commit a4a4573b10 into feature/lifecycle 2024-07-23 12:21:05 +00:00
alexvanin deleted branch feature/epoch_timestamps 2024-07-23 12:21:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#424
No description provided.
Delete branch "mbiryukova/frostfs-s3-gw:feature/epoch_timestamps"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?