bugfix/split_tree_support #431

Merged

alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:bugfix/split_tree_support into support/v0.29 2024-09-04 19:51:14 +00:00

Conversation 0 Commits 1 Files changed 1 +21 -1

dkirillov commented 2024-07-17 06:49:45 +00:00

Member

Copy link

Port #430

Blocked by TrueCloudLab/frostfs-sdk-go#240

Port #430 Blocked by https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/240

dkirillov self-assigned this 2024-07-17 06:49:45 +00:00

dkirillov added 4 commits 2024-07-17 06:50:04 +00:00

[#430] Fix split tree ... 42ba5eddd7

Update tree service to fix split tree problem.
Tree intermediate nodes can be duplicated, so we must handle this.

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>

[#430] tree: Fix multipart having system name ... 5dc672a9aa

Previously if multipart key has the same name as some system node
(e.g. bucket-settings, bucket-cors etc.) it shadows real system node
and bucket started to be unversioned again for example.

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>

[#430] ci: Update go version ... 9e8cf0edaf

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>

[#430] acl: Fix test backward compatibility ... 6dc0b389be

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>

dkirillov force-pushed bugfix/split_tree_support from 6dc0b389be to 0d1131965e 2024-07-17 06:53:59 +00:00 Compare

dkirillov added 3 commits 2024-07-18 13:57:48 +00:00

[#431] tree: Support removing old split system nodes ... c5f61d8a4e

It's need to fit user expectation on deleting CORs for example.
Previously after removing cors (that was uploaded in split manner)
we can still get some data (from other node)
because deletion worked only for latest node version.

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>

[#431] Delete all split version at once ... f00e577ca3

Previously after split we can get two `null` versioned object with the same key
and deleting such key removes only one node/object.

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>

[#431] multipart: Support removing duplicated parts ... 52daf56e5c

Previously after tree split we can have duplicated parts
(several objects and tree node referred to the same part number).
Some of them couldn't be deleted after abort or compete action.

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>

dkirillov force-pushed bugfix/split_tree_support from 52daf56e5c to e9b8d249ce 2024-07-18 14:34:36 +00:00 Compare

dkirillov changed title from WIP: bugfix/split_tree_support to bugfix/split_tree_support 2024-07-18 14:34:48 +00:00

dkirillov requested review from storage-services-committers 2024-07-18 14:35:03 +00:00

dkirillov requested review from storage-services-developers 2024-07-18 14:35:11 +00:00

dkirillov force-pushed bugfix/split_tree_support from e9b8d249ce to 19262730c1 2024-07-19 08:15:26 +00:00 Compare

alexvanin added 1 commit 2024-07-19 11:41:11 +00:00

[#431] Adopt compatibility workarounds in Tree API ... 0707f1e070

Signed-off-by: Alex Vanin <a.vanin@yadro.com>

alexvanin approved these changes 2024-07-19 11:50:08 +00:00

alexvanin merged commit 0707f1e070 into support/v0.29 2024-07-19 11:59:30 +00:00

alexvanin referenced this pull request from a commit 2024-07-19 11:59:35 +00:00

[#431] Fix split tree

alexvanin referenced this pull request from a commit 2024-07-19 11:59:35 +00:00

[#431] tree: Fix multipart having system name

alexvanin referenced this pull request from a commit 2024-07-19 11:59:35 +00:00

[#431] ci: Update go version

alexvanin referenced this pull request from a commit 2024-07-19 11:59:35 +00:00

[#431] acl: Fix test backward compatibility

alexvanin referenced this pull request from a commit 2024-07-19 11:59:35 +00:00

[#431] Delete all split version at once

alexvanin referenced this pull request from a commit 2024-07-19 11:59:35 +00:00

[#431] Adopt compatibility workarounds in Tree API

alexvanin deleted branch bugfix/split_tree_support 2024-07-19 11:59:37 +00:00

alexvanin added this to the v0.29.3 milestone 2024-07-19 14:08:24 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

alexvanin

TrueCloudLab/storage-services-developers

Labels

Clear labels   

P0

Highest

  

P1

High

  

P2

Medium

  

P3

Low

  

good first issue

Good for newcomers

  

Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  

blocked

The issue or PR is blocked by something

  

bug

Something is not working

  

config

Configuration format update or breaking change

  

discussion

Talking about something in order to reach a decision or to exchange ideas

  

documentation

Documentation related

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

go

Language features adoption

  

help wanted

Extra attention is needed

  

internal

  

invalid

Something is wrong

  

kludge

This is a kludge and we know it

  

observability

Related to metrics, tracing and logs

  

perfomance

Perfomance related

  

question

More information is needed

  

refactoring

Refactoring

  

wontfix

This won't be fixed

No labels

P0

P1

P2

P3

good first issue

Infrastructure

blocked

bug

config

discussion

documentation

duplicate

enhancement

go

help wanted

internal

invalid

kludge

observability

perfomance

question

refactoring

wontfix

Milestone

Clear milestone

No items

No milestone

v0.29.3

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

dkirillov

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#431

No description provided.