TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 7 Projects Releases 18 Packages Activity Actions

[#31] Add force bucket delete flag #436

Merged
alexvanin merged 1 commit from pogpp/frostfs-s3-gw:feature/31-full_bucket_removal into master 2024-07-26 06:53:27 +00:00
Conversation 0 Commits 1 Files changed 5 +99 -9
pogpp commented 2024-07-19 19:23:49 +00:00
Member
Copy link

Signed-off-by: Pavel Pogodaev p.pogodaev@yadro.com

Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>
pogpp added 1 commit 2024-07-19 19:24:08 +00:00
[#31] Add force bucket delete flag
Some checks failed
/ DCO (pull_request) Successful in 2m2s
Details
/ Vulncheck (pull_request) Successful in 2m19s
Details
/ Builds (1.21) (pull_request) Successful in 2m32s
Details
/ Builds (1.22) (pull_request) Successful in 2m27s
Details
/ Lint (pull_request) Failing after 2m17s
Details
/ Tests (1.21) (pull_request) Failing after 2m13s
Details
/ Tests (1.22) (pull_request) Failing after 2m46s
Details
93f871cd1f 
Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>
alexvanin reviewed 2024-07-22 06:14:46 +00:00
api/handler/delete.go Outdated
@ -240,0 +240,4 @@
skipObjCheck := false
if value, ok := r.Header[api.AmzForceBucketDelete]; !ok {
h.logAndSendError(w, "missing X-Amz-Force-Delete-Bucket", reqInfo, errors.GetAPIError(errors.ErrMissingForceBucketDeleteHeader))
return
alexvanin commented 2024-07-22 06:14:33 +00:00
Owner
Copy link

This is compatibility-breaking change. We should not fail in case of missing this header.

This is compatibility-breaking change. We should not fail in case of missing this header.
👍 1
alexvanin marked this conversation as resolved
api/layer/layer.go Outdated
@ -794,3 +794,3 @@
}
func (n *Layer) DeleteBucket(ctx context.Context, p *DeleteBucketParams) error {
func (n *Layer) DeleteBucket(ctx context.Context, p *DeleteBucketParams, skipCheck bool) error {
alexvanin commented 2024-07-22 06:14:42 +00:00
Owner
Copy link

Why not put skipcheck in a DeleteBucketParams? Looks quite suitable for this setting.

Why not put `skipcheck` in a `DeleteBucketParams`? Looks quite suitable for this setting.
👍 1
alexvanin marked this conversation as resolved
pogpp force-pushed feature/31-full_bucket_removal from 93f871cd1f to 18cc091545 2024-07-23 13:25:58 +00:00 Compare
pogpp force-pushed feature/31-full_bucket_removal from 18cc091545 to 95dfa4657a 2024-07-23 13:33:49 +00:00 Compare
pogpp requested review from alexvanin 2024-07-23 13:34:36 +00:00
pogpp requested review from mbiryukova 2024-07-23 13:35:11 +00:00
pogpp requested review from dkirillov 2024-07-23 13:35:12 +00:00
pogpp requested review from r.loginov 2024-07-23 13:35:44 +00:00
pogpp force-pushed feature/31-full_bucket_removal from 95dfa4657a to 8e61b055da 2024-07-23 13:39:24 +00:00 Compare
alexvanin reviewed 2024-07-23 13:49:24 +00:00
api/layer/layer.go Outdated
@ -813,3 +814,3 @@
return err
}
if len(res) != 0 {
if len(res) != 0 && !p.SkipCheck {
alexvanin commented 2024-07-23 13:49:22 +00:00
Owner
Copy link

I appreciate small changes, it looks very nice and clean.

However, I am not sure it is worth keeping n.getAllObjectVersions when we can skip it entirely if SkipCheck == true.

I appreciate small changes, it looks very nice and clean. However, I am not sure it is worth keeping `n.getAllObjectVersions` when we can skip it entirely if `SkipCheck == true`.
👍 1
dkirillov commented 2024-07-24 07:55:12 +00:00
Member
Copy link

Also it would be nice to have tests for this new behavior

Also it would be nice to have tests for this new behavior
👍 2
alexvanin marked this conversation as resolved
docs/extensions.md Outdated
@ -0,0 +34,4 @@
```text
DELETE / HTTP/1.1
Host: data.s3.<Region>.frostfs-s3-gw.com
alexvanin commented 2024-07-23 13:46:41 +00:00
Owner
Copy link

There should be X-Amz-Force-Delete-Bucket: true header as well.

There should be `X-Amz-Force-Delete-Bucket: true` header as well.
👍 1
alexvanin marked this conversation as resolved
pogpp changed title from WIP: [#31] Add force bucket delete flag to [#31] Add force bucket delete flag 2024-07-25 07:45:11 +00:00
pogpp changed title from [#31] Add force bucket delete flag to [#31] Add force bucket delete flag 2024-07-25 07:45:26 +00:00
pogpp force-pushed feature/31-full_bucket_removal from 8e61b055da to 9c0b781193 2024-07-25 10:54:44 +00:00 Compare
pogpp force-pushed feature/31-full_bucket_removal from 9c0b781193 to 51c5c227c2 2024-07-25 11:05:04 +00:00 Compare
alexvanin approved these changes 2024-07-25 12:55:28 +00:00
alexvanin left a comment
Owner
Copy link

Looks great!

Looks great!
dkirillov reviewed 2024-07-25 14:26:47 +00:00
api/handler/delete_test.go
@ -517,6 +535,13 @@ func deleteObjectsBase(hc *handlerContext, bktName string, objVersions [][2]stri
return w
}
func deleteBucketForce(t *testing.T, tc *handlerContext, bktName string, code int, value string) {
dkirillov commented 2024-07-25 14:26:47 +00:00
Member
Copy link

Minor (non-blocking): it's better to write

func deleteBucketForce(t *testing.T, tc *handlerContext, bktName string, value bool, code int) {
Minor (non-blocking): it's better to write ``` func deleteBucketForce(t *testing.T, tc *handlerContext, bktName string, value bool, code int) { ```
dkirillov approved these changes 2024-07-25 14:27:17 +00:00
alexvanin merged commit 51c5c227c2 into master 2024-07-26 06:53:27 +00:00
alexvanin deleted branch feature/31-full_bucket_removal 2024-07-26 06:53:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
mbiryukova
r.loginov
alexvanin
dkirillov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#436
No description provided.
Delete branch "pogpp/frostfs-s3-gw:feature/31-full_bucket_removal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?