TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 6 Projects Releases 18 Packages Activity Actions

[#369] Modify http logging #441

Merged
nzinkevich merged 1 commit from nzinkevich/frostfs-s3-gw:feature/log_response into feature/369 2024-09-04 19:51:14 +00:00
Conversation 0 Commits 1 Files changed 6 +49 -15
nzinkevich commented 2024-07-24 08:51:36 +00:00
Member
Copy link
No description provided.
dkirillov was assigned by nzinkevich 2024-07-24 08:51:36 +00:00
pogpp was assigned by nzinkevich 2024-07-24 08:51:36 +00:00
nzinkevich added 3 commits 2024-07-24 08:51:40 +00:00 
Signed-off-by: Nikita Zinkevich <n.zinkevich@yadro.com>
Signed-off-by: Nikita Zinkevich <n.zinkevich@yadro.com>
[#369] Add response logging
All checks were successful
/ DCO (pull_request) Successful in 45s
Details
/ Builds (1.20) (pull_request) Successful in 1m36s
Details
/ Builds (1.21) (pull_request) Successful in 1m29s
Details
/ Vulncheck (pull_request) Successful in 2m29s
Details
/ Lint (pull_request) Successful in 2m45s
Details
/ Tests (1.20) (pull_request) Successful in 1m45s
Details
/ Tests (1.21) (pull_request) Successful in 1m42s
Details
e530031c10 
Signed-off-by: Nikita Zinkevich <n.zinkevich@yadro.com>
nzinkevich changed title from Modify http logging to [#369] Modify http logging 2024-07-24 08:52:59 +00:00
dkirillov was unassigned by nzinkevich 2024-07-24 09:07:50 +00:00
pogpp was unassigned by nzinkevich 2024-07-24 09:07:50 +00:00
nzinkevich requested review from pogpp 2024-07-24 09:07:57 +00:00
alexvanin requested changes 2024-07-24 09:39:59 +00:00
docs/configuration.md Outdated
@ -390,3 +391,3 @@
|----------------|--------|---------------|---------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `enabled` | bool | yes | false | Flag to enable the logger. |
| `max_body` | int | yes | 1024 | Max body size for log output in bytes. |
| `max_body` | int | yes | 10 | Max size for request and response bodies that will be attached to the log (in megabytes). |
alexvanin commented 2024-07-24 09:39:54 +00:00
Owner
Copy link

If we want more usability, then we have to support strings with k and m suffixes, e.g.
10m, 100k` etc.

Until then, use just bytes.

If we want more usability, then we have to support strings with `k` and `m` suffixes, e.g. `10m`, 100k` etc. Until then, use just bytes.
nzinkevich force-pushed feature/log_response from e530031c10 to 5d55934748 2024-07-24 10:36:50 +00:00 Compare
alexvanin approved these changes 2024-07-24 10:52:26 +00:00
nzinkevich merged commit 5d55934748 into feature/369 2024-07-24 10:53:01 +00:00
nzinkevich deleted branch feature/log_response 2024-07-24 10:53:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pogpp
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#441
No description provided.
Delete branch "nzinkevich/frostfs-s3-gw:feature/log_response"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?