TrueCloudLab/frostfs-s3-gw
15
2
Fork 17
Code Issues 22 Pull requests 7 Projects Releases 13 Packages Activity Actions

[#42] Fix using separate container for lifecycles #442

Merged
alexvanin merged 1 commit from mbiryukova/frostfs-s3-gw:feature/lifecycle_container into feature/lifecycle 2024-09-04 19:51:14 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
mbiryukova commented 2024-07-24 09:39:20 +00:00
Member
Copy link

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2024-07-24 09:39:21 +00:00
mbiryukova added 1 commit 2024-07-24 09:39:23 +00:00
[#42] Fix using separate container for lifecycles
All checks were successful
/ DCO (pull_request) Successful in 1m11s
Details
/ Builds (1.21) (pull_request) Successful in 1m23s
Details
/ Builds (1.22) (pull_request) Successful in 1m21s
Details
/ Vulncheck (pull_request) Successful in 4m33s
Details
/ Lint (pull_request) Successful in 5m56s
Details
/ Tests (1.21) (pull_request) Successful in 1m7s
Details
/ Tests (1.22) (pull_request) Successful in 1m22s
Details
5863af4a26 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova requested review from storage-services-committers 2024-07-24 09:46:17 +00:00
mbiryukova requested review from storage-services-developers 2024-07-24 09:46:18 +00:00
alexvanin approved these changes 2024-07-24 12:26:22 +00:00
alexvanin left a comment
Owner
Copy link

This is going to be quite nasty rebase after tree split PR. But it is what it is.

This is going to be quite nasty rebase after tree split PR. But it is what it is.
api/layer/layer.go Outdated
@ -821,0 +830,4 @@
if !lifecycleObj.Container().Equals(p.BktInfo.CID) {
n.deleteLifecycleObject(ctx, p.BktInfo, lifecycleObj)
}
alexvanin commented 2024-07-24 12:23:31 +00:00
Owner
Copy link

This order looks a bit weird at the first glance. Is there a reason to get lifecycleObj before deleting container?

This order looks a bit weird at the first glance. Is there a reason to get `lifecycleObj` before deleting container?
mbiryukova commented 2024-07-24 13:25:02 +00:00
Author
Member
Copy link

If we try to get lifecycleObj after deletion, we'll get an error that container not found

If we try to get `lifecycleObj` after deletion, we'll get an error that container not found
mbiryukova force-pushed feature/lifecycle_container from 5863af4a26 to 2abb9b38cc 2024-07-24 13:26:24 +00:00 Compare
dkirillov reviewed 2024-07-25 08:08:02 +00:00
api/layer/lifecycle.go
@ -146,0 +143,4 @@
prmAuth.PrivateKey = &n.gateKey.PrivateKey
}
if err = n.objectDeleteWithAuth(ctx, lifecycleBkt, obj.Object(), prmAuth); err != nil {
dkirillov commented 2024-07-25 08:08:02 +00:00
Member
Copy link

It seems we can reuse deleteLifecycleObject if make it more general (let it return error)

It seems we can reuse `deleteLifecycleObject` if make it more general (let it return error)
mbiryukova commented 2024-07-26 09:35:08 +00:00
Author
Member
Copy link

Log and return?

Log and return?
dkirillov commented 2024-07-26 12:40:35 +00:00
Member
Copy link

I wouldn't log inside it, but then we have to log in more other places so I don't know what is better.
Let's leave everything as is.

I wouldn't log inside it, but then we have to log in more other places so I don't know what is better. Let's leave everything as is.
🚀 1
dkirillov approved these changes 2024-07-25 08:09:55 +00:00
alexvanin merged commit 2abb9b38cc into feature/lifecycle 2024-07-26 13:08:26 +00:00
alexvanin deleted branch feature/lifecycle_container 2024-07-26 13:08:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
dkirillov
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#442
No description provided.
Delete branch "mbiryukova/frostfs-s3-gw:feature/lifecycle_container"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?