TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 6 Projects Releases 18 Packages Activity Actions

port: tree: Support removing old split system nodes #444

Merged
alexvanin merged 2 commits from alexvanin/frostfs-s3-gw:port/settings-split into master 2024-07-26 06:54:10 +00:00
Conversation 0 Commits 2 Files changed 5 +160 -93
alexvanin commented 2024-07-24 13:21:35 +00:00
Owner
Copy link

It's need to fit user expectation on deleting CORS for example. Previously after removing cors (that was uploaded in split manner) we can still get some data (from other node) because deletion worked only for latest node version.

Port of #437 into master

It's need to fit user expectation on deleting CORS for example. Previously after removing cors (that was uploaded in split manner) we can still get some data (from other node) because deletion worked only for latest node version. Port of #437 into master
alexvanin self-assigned this 2024-07-24 13:21:35 +00:00
alexvanin added 1 commit 2024-07-24 13:21:38 +00:00
[#437] tree: Support removing old split system nodes
Some checks failed
/ Builds (1.21) (pull_request) Successful in 1m30s
Details
/ Builds (1.22) (pull_request) Successful in 1m37s
Details
/ Lint (pull_request) Failing after 1m17s
Details
/ Tests (1.21) (pull_request) Successful in 1m44s
Details
/ Tests (1.22) (pull_request) Successful in 1m42s
Details
/ Vulncheck (pull_request) Successful in 2m8s
Details
/ DCO (pull_request) Successful in 5m52s
Details
c81f3df9e3 
It's need to fit user expectation on deleting CORs for example.
Previously after removing cors (that was uploaded in split manner)
we can still get some data (from other node)
because deletion worked only for latest node version.

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
Signed-off-by: Alex Vanin <a.vanin@yadro.com>
alexvanin requested review from dkirillov 2024-07-24 13:22:00 +00:00
alexvanin requested review from mbiryukova 2024-07-24 13:22:02 +00:00
alexvanin reviewed 2024-07-24 13:23:06 +00:00
api/layer/cors.go Outdated
@ -118,2 +113,2 @@
if err = n.objectDeleteWithAuth(ctx, corsBkt, obj.Object(), prmAuth); err != nil {
return fmt.Errorf("delete cors object: %w", err)
for _, addr := range objs {
n.deleteCORSObject(ctx, bktInfo, addr)
alexvanin commented 2024-07-24 13:22:58 +00:00
Author
Owner
Copy link

@mbiryukova is this change legal? We've used deleteCORSObject in PutBucketCORS so I've decided to reuse it in DeleteBucketCORS. Can I do that?

@mbiryukova is this change legal? We've used `deleteCORSObject` in `PutBucketCORS` so I've decided to reuse it in `DeleteBucketCORS`. Can I do that?
mbiryukova commented 2024-07-24 13:53:26 +00:00
Member
Copy link

The only difference is that error was returned. With multiple deletions I guess it's ok to just log them

The only difference is that error was returned. With multiple deletions I guess it's ok to just log them
alexvanin marked this conversation as resolved
alexvanin force-pushed port/settings-split from c81f3df9e3 to 5baa6c045d 2024-07-24 13:23:53 +00:00 Compare
alexvanin force-pushed port/settings-split from 5baa6c045d to 41eda7aa35 2024-07-24 13:32:11 +00:00 Compare
dkirillov reviewed 2024-07-24 13:42:24 +00:00
pkg/service/tree/tree.go Outdated
@ -510,3 +566,4 @@
return objToDelete, nil
}
func getCORSAddress(node *treeNode) (oid.Address, error) {
dkirillov commented 2024-07-24 13:42:24 +00:00
Member
Copy link

Let's rename this function to getTreeNodeAddress for example

Let's rename this function to `getTreeNodeAddress` for example
👍 2
dkirillov approved these changes 2024-07-24 13:43:28 +00:00
mbiryukova approved these changes 2024-07-24 14:01:57 +00:00
alexvanin added 1 commit 2024-07-25 13:06:45 +00:00
[#437] Rename getCORSAddress
All checks were successful
/ DCO (pull_request) Successful in 1m11s
Details
/ Vulncheck (pull_request) Successful in 1m13s
Details
/ Builds (1.21) (pull_request) Successful in 1m26s
Details
/ Builds (1.22) (pull_request) Successful in 1m27s
Details
/ Lint (pull_request) Successful in 2m16s
Details
/ Tests (1.21) (pull_request) Successful in 1m34s
Details
/ Tests (1.22) (pull_request) Successful in 1m24s
Details
002dc2e658 
This function is going to be reused
for lifecycles as well.

Signed-off-by: Alex Vanin <a.vanin@yadro.com>
dkirillov approved these changes 2024-07-25 14:45:47 +00:00
alexvanin merged commit c34680d157 into master 2024-07-26 06:54:10 +00:00
alexvanin deleted branch port/settings-split 2024-07-26 06:54:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
mbiryukova
dkirillov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
alexvanin
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#444
No description provided.
Delete branch "alexvanin/frostfs-s3-gw:port/settings-split"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?