TrueCloudLab/frostfs-s3-gw
15
2
Fork 17
Code Issues 22 Pull requests 7 Projects Releases 13 Packages Activity Actions

Add support X-Frostfs-S3-VHS and X-Frostfs-Servername headers #449

Merged
r.loginov merged 1 commit from r.loginov/frostfs-s3-gw:feature/vhs_header into feature/virtual-hosted-style 2024-08-16 12:41:05 +00:00
Conversation 0 Commits 1 Files changed 9 +141 -19
r.loginov commented 2024-08-01 14:38:04 +00:00
Member
Copy link
No description provided.
r.loginov self-assigned this 2024-08-01 14:38:05 +00:00
r.loginov added 3 commits 2024-08-01 14:38:09 +00:00 
Signed-off-by: Roman Loginov <r.loginov@yadro.com>
[#446] Add tests for address style middleware
All checks were successful
/ DCO (pull_request) Successful in 1m8s
Details
/ Vulncheck (pull_request) Successful in 1m17s
Details
/ Builds (1.21) (pull_request) Successful in 1m26s
Details
/ Builds (1.22) (pull_request) Successful in 1m24s
Details
/ Lint (pull_request) Successful in 2m5s
Details
/ Tests (1.21) (pull_request) Successful in 1m46s
Details
/ Tests (1.22) (pull_request) Successful in 1m41s
Details
94070b107b 
Signed-off-by: Roman Loginov <r.loginov@yadro.com>
[##] Add support header for vhs and servername
Some checks failed
/ DCO (pull_request) Failing after 1m9s
Details
/ Vulncheck (pull_request) Successful in 1m15s
Details
/ Builds (1.21) (pull_request) Successful in 1m23s
Details
/ Builds (1.22) (pull_request) Successful in 1m28s
Details
/ Lint (pull_request) Successful in 2m1s
Details
/ Tests (1.21) (pull_request) Successful in 1m38s
Details
/ Tests (1.22) (pull_request) Successful in 1m33s
Details
745a562848 
Signed-off-by: Roman Loginov <r.loginov@yadro.com>
r.loginov force-pushed feature/vhs_header from 745a562848 to a7187ad956 2024-08-01 14:40:34 +00:00 Compare
alexvanin changed title from WIP: Add support X-Frostfs-S3-VHS and X-Frostfs-Servername headers to WIP: Add support X-Frostfs-S3-VHS and X-Frostfs-Servername headers 2024-08-02 08:12:39 +00:00
alexvanin changed target branch from master to feature/virtual-hosted-style 2024-08-02 08:12:40 +00:00
r.loginov changed title from WIP: Add support X-Frostfs-S3-VHS and X-Frostfs-Servername headers to Add support X-Frostfs-S3-VHS and X-Frostfs-Servername headers 2024-08-02 08:19:26 +00:00
dkirillov approved these changes 2024-08-05 09:34:05 +00:00
docs/configuration.md Outdated
@ -742,1 +739,3 @@
| `namespaces` | `map[string]bool` | yes | | A map in which the keys are the name of the namespace, and the values are the flag responsible for enabling VHS for the specified namespace. |
| Parameter | Type | SIGHUP reload | Default value | Description |
|---------------------|-------------------|---------------|------------------------|----------------------------------------------------------------------------------------------------------------------------------------------|
| `enabled` | `bool` | yes | `false` | Enables the use of virtual host addressing for banquets at the application level. |
dkirillov commented 2024-08-05 09:32:58 +00:00
Member
Copy link

banquets means buckets?

`banquets` means `buckets`?
👍 1
dkirillov marked this conversation as resolved
docs/configuration.md Outdated
@ -743,0 +740,4 @@
|---------------------|-------------------|---------------|------------------------|----------------------------------------------------------------------------------------------------------------------------------------------|
| `enabled` | `bool` | yes | `false` | Enables the use of virtual host addressing for banquets at the application level. |
| `vhs_header` | `string` | yes | `X-Frostfs-S3-VHS` | Header for determining whether VHS is enabled for the request. |
| `servername_header` | `string` | yes | `X-Frostfs-Servername` | Header for determining servername. |
dkirillov commented 2024-08-05 09:32:35 +00:00
Member
Copy link

Please add this parameters in the example above

Please add this parameters in the example above
👍 1
dkirillov marked this conversation as resolved
r.loginov force-pushed feature/vhs_header from a7187ad956 to e906ec99de 2024-08-06 06:02:02 +00:00 Compare
dkirillov reviewed 2024-08-06 06:41:42 +00:00
docs/configuration.md Outdated
@ -742,1 +741,3 @@
| `namespaces` | `map[string]bool` | yes | | A map in which the keys are the name of the namespace, and the values are the flag responsible for enabling VHS for the specified namespace. |
| Parameter | Type | SIGHUP reload | Default value | Description |
|---------------------|-------------------|---------------|------------------------|----------------------------------------------------------------------------------------------------------------------------------------------|
| `enabled` | `bool` | yes | `false` | Enables the use of virtual host addressing for buckets at the application level. |
dkirillov commented 2024-08-06 06:41:42 +00:00
Member
Copy link

Please, reformat table.

diff --git a/docs/configuration.md b/docs/configuration.md
index 3747c406..2a2dd113 100644
--- a/docs/configuration.md
+++ b/docs/configuration.md
@@ -740,7 +740,7 @@ vhs:
 
 | Parameter           | Type              | SIGHUP reload | Default value          | Description                                                                                                                                  |
 |---------------------|-------------------|---------------|------------------------|----------------------------------------------------------------------------------------------------------------------------------------------|
-| `enabled`           | `bool`            | yes           | `false`                | Enables the use of virtual host addressing for buckets at the application level.                                                            |
+| `enabled`           | `bool`            | yes           | `false`                | Enables the use of virtual host addressing for buckets at the application level.                                                             |
 | `vhs_header`        | `string`          | yes           | `X-Frostfs-S3-VHS`     | Header for determining whether VHS is enabled for the request.                                                                               |
 | `servername_header` | `string`          | yes           | `X-Frostfs-Servername` | Header for determining servername.                                                                                                           |
 | `namespaces`        | `map[string]bool` | yes           |                        | A map in which the keys are the name of the namespace, and the values are the flag responsible for enabling VHS for the specified namespace. |
Please, reformat table. ```diff diff --git a/docs/configuration.md b/docs/configuration.md index 3747c406..2a2dd113 100644 --- a/docs/configuration.md +++ b/docs/configuration.md @@ -740,7 +740,7 @@ vhs: | Parameter | Type | SIGHUP reload | Default value | Description | |---------------------|-------------------|---------------|------------------------|----------------------------------------------------------------------------------------------------------------------------------------------| -| `enabled` | `bool` | yes | `false` | Enables the use of virtual host addressing for buckets at the application level. | +| `enabled` | `bool` | yes | `false` | Enables the use of virtual host addressing for buckets at the application level. | | `vhs_header` | `string` | yes | `X-Frostfs-S3-VHS` | Header for determining whether VHS is enabled for the request. | | `servername_header` | `string` | yes | `X-Frostfs-Servername` | Header for determining servername. | | `namespaces` | `map[string]bool` | yes | | A map in which the keys are the name of the namespace, and the values are the flag responsible for enabling VHS for the specified namespace. | ```
👍 1
r.loginov force-pushed feature/vhs_header from e906ec99de to 2997613002 2024-08-06 12:02:24 +00:00 Compare
dkirillov approved these changes 2024-08-06 12:50:32 +00:00
r.loginov merged commit 2997613002 into feature/virtual-hosted-style 2024-08-16 12:41:05 +00:00
r.loginov deleted branch feature/vhs_header 2024-08-16 12:41:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
r.loginov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#449
No description provided.
Delete branch "r.loginov/frostfs-s3-gw:feature/vhs_header"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?