feature/lifecycle_port #458

Closed
mbiryukova wants to merge 5 commits from mbiryukova/frostfs-s3-gw:feature/lifecycle_port into master
Member
No description provided.
mbiryukova self-assigned this 2024-08-12 14:53:50 +00:00
mbiryukova added 5 commits 2024-08-12 14:53:55 +00:00
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
[#452] tree: Fix logging
All checks were successful
/ DCO (pull_request) Successful in 1m10s
/ Vulncheck (pull_request) Successful in 1m14s
/ Builds (1.21) (pull_request) Successful in 1m27s
/ Builds (1.22) (pull_request) Successful in 1m30s
/ Lint (pull_request) Successful in 2m22s
/ Tests (1.21) (pull_request) Successful in 1m28s
/ Tests (1.22) (pull_request) Successful in 1m39s
924349c1c5
Don't log parsing tags error in listing

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
mbiryukova requested review from storage-services-committers 2024-08-12 15:06:32 +00:00
mbiryukova requested review from storage-services-developers 2024-08-12 15:06:32 +00:00
dkirillov reviewed 2024-08-13 06:54:11 +00:00
@ -1450,0 +1537,4 @@
objToDelete := c.cleanOldNodes(ctx, multiNode.nodes, bktInfo)
if len(objToDelete) != len(multiNode.nodes) {
return nil, fmt.Errorf("clean old lifecycle nodes: %w", err)
Member

err is nil here

`err` is nil here
Author
Member

Fixed this and the same for cors

Fixed this and the same for cors
dkirillov reviewed 2024-08-13 06:55:14 +00:00
@ -81,10 +81,17 @@ func (h *handler) DeleteObjectHandler(w http.ResponseWriter, r *http.Request) {
return
}
networkInfo, err := h.obj.GetNetworkInfo(ctx)
Member

Can we consider using cache for network info?

Can we consider using cache for network info?
Author
Member

The same PR from another branch: #459

The same PR from another branch: https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/pulls/459
mbiryukova closed this pull request 2024-08-13 09:50:34 +00:00
All checks were successful
/ DCO (pull_request) Successful in 1m10s
/ Vulncheck (pull_request) Successful in 1m14s
/ Builds (1.21) (pull_request) Successful in 1m27s
/ Builds (1.22) (pull_request) Successful in 1m30s
/ Lint (pull_request) Successful in 2m22s
/ Tests (1.21) (pull_request) Successful in 1m28s
/ Tests (1.22) (pull_request) Successful in 1m39s

Pull request closed

Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#458
No description provided.