TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 6 Projects Releases 18 Packages Activity Actions

[#471] tree: Don't use sorted GetSubTree for nodes without FileName #471

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:bugfix/sorted_get_sub_tree_support into support/v0.30 2024-08-27 09:41:50 +00:00
Conversation 0 Commits 1 Files changed 4 +22 -10
dkirillov commented 2024-08-21 12:14:50 +00:00
Member
Copy link

Sorted GetSubTree doesn't return nodes without FileName attribute
if there are more than 1000 nodes in subtree

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Sorted GetSubTree doesn't return nodes without FileName attribute if there are more than 1000 nodes in subtree Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2024-08-21 12:14:51 +00:00
dkirillov added 1 commit 2024-08-21 12:14:53 +00:00
[#XX] tree: Don't use sorted GetSubTree for nodes without FileName
Some checks failed
/ DCO (pull_request) Failing after 1m21s
Details
/ Vulncheck (pull_request) Successful in 1m41s
Details
/ Builds (1.21) (pull_request) Successful in 1m52s
Details
/ Builds (1.22) (pull_request) Successful in 2m6s
Details
/ Lint (pull_request) Failing after 2m20s
Details
/ Tests (1.21) (pull_request) Failing after 1m57s
Details
/ Tests (1.22) (pull_request) Failing after 1m54s
Details
812bae15db 
Sorted GetSubTree doesn't return nodes without FileName attribute
if there are more than 1000 nodes in subtree

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov changed title from WIP: [#XX] tree: Don't use sorted GetSubTree for nodes without FileName to WIP: [#471] tree: Don't use sorted GetSubTree for nodes without FileName 2024-08-21 12:15:02 +00:00
dkirillov force-pushed bugfix/sorted_get_sub_tree_support from 812bae15db to fdbfd89b85 2024-08-21 12:15:43 +00:00 Compare
dkirillov force-pushed bugfix/sorted_get_sub_tree_support from fdbfd89b85 to a7ae88e1fb 2024-08-21 12:26:28 +00:00 Compare
dkirillov requested review from storage-services-committers 2024-08-21 12:27:35 +00:00
dkirillov requested review from storage-services-developers 2024-08-21 12:27:39 +00:00
dkirillov changed title from WIP: [#471] tree: Don't use sorted GetSubTree for nodes without FileName to [#471] tree: Don't use sorted GetSubTree for nodes without FileName 2024-08-27 09:36:12 +00:00
alexvanin approved these changes 2024-08-27 09:41:45 +00:00
alexvanin merged commit a7ae88e1fb into support/v0.30 2024-08-27 09:41:49 +00:00
alexvanin deleted branch bugfix/sorted_get_sub_tree_support 2024-08-27 09:41:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#471
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:bugfix/sorted_get_sub_tree_support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?