TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 6 Projects Releases 18 Packages Activity Actions

[#472] tree: Don't use sorted GetSubTree for nodes without FileName #472

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:bugfix/sorted_get_sub_tree into master 2024-08-27 09:43:29 +00:00
Conversation 1 Commits 1 Files changed 4 +22 -10
dkirillov commented 2024-08-21 12:17:13 +00:00
Member
Copy link

Sorted GetSubTree doesn't return nodes without FileName attribute
if there are more than 1000 nodes in subtree

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Sorted GetSubTree doesn't return nodes without FileName attribute if there are more than 1000 nodes in subtree Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2024-08-21 12:17:13 +00:00
dkirillov added 1 commit 2024-08-21 12:17:25 +00:00
[#472] tree: Don't use sorted GetSubTree for nodes without FileName
Some checks failed
/ DCO (pull_request) Successful in 1m35s
Details
/ Vulncheck (pull_request) Successful in 2m10s
Details
/ Builds (1.21) (pull_request) Successful in 2m15s
Details
/ Builds (1.22) (pull_request) Successful in 2m9s
Details
/ Lint (pull_request) Failing after 2m12s
Details
/ Tests (1.21) (pull_request) Failing after 2m26s
Details
/ Tests (1.22) (pull_request) Failing after 2m8s
Details
68e0c18ada 
Sorted GetSubTree doesn't return nodes without FileName attribute
if there are more than 1000 nodes in subtree

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov force-pushed bugfix/sorted_get_sub_tree from 68e0c18ada to 2a48b022b9 2024-08-21 12:24:36 +00:00 Compare
dkirillov requested review from storage-services-committers 2024-08-21 12:27:30 +00:00
dkirillov requested review from storage-services-developers 2024-08-21 12:27:35 +00:00
alexvanin commented 2024-08-22 14:02:34 +00:00
Owner
Copy link

I think we can remove WIP on master branch fix.

I think we can remove WIP on master branch fix.
alexvanin reviewed 2024-08-22 14:08:43 +00:00
pkg/service/tree/tree.go
@ -35,3 +35,3 @@
GetNodes(ctx context.Context, p *GetNodesParams) ([]NodeResponse, error)
GetSubTree(ctx context.Context, bktInfo *data.BucketInfo, treeID string, rootID []uint64, depth uint32) ([]NodeResponse, error)
GetSubTree(ctx context.Context, bktInfo *data.BucketInfo, treeID string, rootID []uint64, depth uint32, sort bool) ([]NodeResponse, error)
GetSubTreeStream(ctx context.Context, bktInfo *data.BucketInfo, treeID string, rootID []uint64, depth uint32) (SubTreeStream, error)
alexvanin commented 2024-08-22 14:08:43 +00:00
Owner
Copy link

If we going to use streaming later in #469, shouldn't we adopt sort flag in streaming method too? Or it won't be used for anything besides getSubTreeMultipartUpload?

If we going to use streaming later in https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/issues/469, shouldn't we adopt `sort` flag in streaming method too? Or it won't be used for anything besides `getSubTreeMultipartUpload`?
dkirillov commented 2024-08-22 14:18:59 +00:00
Author
Member
Copy link

We should adopt this flag only if we start streaming parts and not only multiparts

We should adopt this flag only if we start streaming parts and not only multiparts
👍 1
alexvanin marked this conversation as resolved
alexvanin approved these changes 2024-08-23 08:32:17 +00:00
dkirillov force-pushed bugfix/sorted_get_sub_tree from 2a48b022b9 to 75e536492a 2024-08-26 07:45:09 +00:00 Compare
dkirillov changed title from WIP: [#472] tree: Don't use sorted GetSubTree for nodes without FileName to [#472] tree: Don't use sorted GetSubTree for nodes without FileName 2024-08-26 07:45:49 +00:00
alexvanin added this to the v0.30.3 milestone 2024-08-27 09:43:24 +00:00
alexvanin merged commit d76c4fe2a2 into master 2024-08-27 09:43:29 +00:00
alexvanin deleted branch bugfix/sorted_get_sub_tree 2024-08-27 09:43:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.30.3
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#472
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:bugfix/sorted_get_sub_tree"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?