TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 7 Projects Releases 18 Packages Activity Actions

feature/patch #479

Merged
alexvanin merged 4 commits from feature/patch into master 2024-09-03 11:58:00 +00:00
Conversation 0 Commits 4 Files changed 18 +1304 -3
mbiryukova commented 2024-08-30 09:54:11 +00:00
Member
Copy link
No description provided.
mbiryukova self-assigned this 2024-08-30 09:54:12 +00:00
mbiryukova added 3 commits 2024-08-30 09:54:37 +00:00 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
[#466] Implement PATCH for multipart objects
All checks were successful
/ DCO (pull_request) Successful in 2m56s
Details
/ Builds (1.22) (pull_request) Successful in 3m18s
Details
/ Builds (1.23) (pull_request) Successful in 3m12s
Details
/ Vulncheck (pull_request) Successful in 3m6s
Details
/ Lint (pull_request) Successful in 3m42s
Details
/ Tests (1.22) (pull_request) Successful in 3m26s
Details
/ Tests (1.23) (pull_request) Successful in 3m27s
Details
714af94de5 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova requested review from storage-services-committers 2024-08-30 09:58:48 +00:00
mbiryukova requested review from storage-services-developers 2024-08-30 09:58:48 +00:00
dkirillov reviewed 2024-08-30 14:15:09 +00:00
api/handler/patch.go Outdated
@ -0,0 +15,4 @@
"go.uber.org/zap"
)
const maxPatchSize = 5 * 1024 * 1024 * 1024
dkirillov commented 2024-08-30 14:15:09 +00:00
Member
Copy link

It would be nice to write

const maxPatchSize = 5 * 1024 * 1024 * 1024 // 5GB
It would be nice to write ```golang const maxPatchSize = 5 * 1024 * 1024 * 1024 // 5GB ```
dkirillov marked this conversation as resolved
dkirillov reviewed 2024-08-30 14:21:12 +00:00
api/layer/layer.go Outdated
@ -535,6 +547,229 @@ func (n *Layer) CopyObject(ctx context.Context, p *CopyObjectParams) (*data.Exte
})
}
func (n *Layer) PatchObject(ctx context.Context, p *PatchObjectParams) (*data.ExtendedObjectInfo, error) {
dkirillov commented 2024-08-30 14:21:12 +00:00
Member
Copy link

Let's add these new methods in new file patch.go

Let's add these new methods in new file `patch.go`
dkirillov marked this conversation as resolved
dkirillov reviewed 2024-08-30 14:22:51 +00:00
api/layer/layer.go Outdated
@ -538,0 +623,4 @@
}, nil
}
func (n *Layer) patchMultipartObject(ctx context.Context, p *PatchObjectParams) (*data.ExtendedObjectInfo, error) {
dkirillov commented 2024-08-30 14:22:51 +00:00
Member
Copy link

This method has lenght ~150. Can we split it to several functions?

This method has lenght ~150. Can we split it to several functions?
dkirillov marked this conversation as resolved
dkirillov reviewed 2024-08-30 14:24:08 +00:00
dkirillov left a comment
Member
Copy link

Please, update CHANGELOG.md

It seems we should also update policy-engine to support PatchObject in APE (to be able to use this action in PutBucketPolicy)

Please, update CHANGELOG.md It seems we should also update policy-engine to support `PatchObject` in APE (to be able to use this action in `PutBucketPolicy`)
mbiryukova force-pushed feature/patch from 714af94de5 to 72e983e4e2 2024-09-02 08:53:21 +00:00 Compare
alexvanin approved these changes 2024-09-02 13:30:15 +00:00
dkirillov approved these changes 2024-09-02 13:45:16 +00:00
alexvanin merged commit 9bdfe2a016 into master 2024-09-03 11:57:59 +00:00
alexvanin deleted branch feature/patch 2024-09-03 11:58:01 +00:00
alexvanin added this to the v0.31.0 milestone 2024-11-20 11:59:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
dkirillov
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.31.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#479
No description provided.
Delete branch "feature/patch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?