TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 7 Projects Releases 17 Packages Activity Actions

#484 Add root ca cert for telemetry configuration #485

Merged
alexvanin merged 1 commit from AlekseySVTN/frostfs-s3-gw:add-root-ca-cert-for-telemetry-configuration into master 2024-09-19 11:07:13 +00:00
Conversation 0 Commits 1 Files changed 7 +102 -125
AlekseySVTN commented 2024-09-10 08:04:03 +00:00
Member
Copy link

Signed-off-by: Aleksey Savaitan a.savaitan@yadro.com

Signed-off-by: Aleksey Savaitan <a.savaitan@yadro.com>
AlekseySVTN added 1 commit 2024-09-10 08:04:03 +00:00
#484 Add root ca cert for telemetry configuration
Some checks failed
/ DCO (pull_request) Failing after 51s
Details
/ Vulncheck (pull_request) Failing after 1m10s
Details
/ Builds (pull_request) Failing after 1m24s
Details
/ Lint (pull_request) Failing after 1m26s
Details
/ Tests (pull_request) Successful in 1m25s
Details
523ba91c5c 
Signed-off-by: Aleksey Savaitan <a.savaitan@yadro.com>
fyrchik requested changes 2024-09-10 08:10:48 +00:00
cmd/s3-gw/app_settings.go Outdated
@ -147,6 +147,7 @@ const ( // Settings.
cfgTracingEnabled = "tracing.enabled"
cfgTracingExporter = "tracing.exporter"
cfgTracingEndpoint = "tracing.endpoint"
cfgTracingCaCert = "tracing.caCert"
fyrchik commented 2024-09-10 08:10:41 +00:00
Owner
Copy link

Please, use trusted_ca_list, we already have similar setting for neo-go mTLS in node.

Please, use `trusted_ca_list`, we already have similar setting for neo-go mTLS in node.
fyrchik commented 2024-09-10 08:15:08 +00:00
Owner
Copy link

Probably makes no sense to use multiple certificate here, though.

Probably makes no sense to use multiple certificate here, though.
AlekseySVTN commented 2024-09-12 10:34:19 +00:00
Author
Member
Copy link

We have decided to use trusted_ca.

We have decided to use trusted_ca.
AlekseySVTN force-pushed add-root-ca-cert-for-telemetry-configuration from 523ba91c5c to 75de1db3b6 2024-09-10 08:58:44 +00:00 Compare
AlekseySVTN force-pushed add-root-ca-cert-for-telemetry-configuration from 75de1db3b6 to 26aa31f8a6 2024-09-12 08:20:32 +00:00 Compare
AlekseySVTN force-pushed add-root-ca-cert-for-telemetry-configuration from 26aa31f8a6 to 5f98f1a301 2024-09-12 09:36:27 +00:00 Compare
AlekseySVTN force-pushed add-root-ca-cert-for-telemetry-configuration from 5f98f1a301 to 5e055c5b7b 2024-09-12 10:14:15 +00:00 Compare
AlekseySVTN force-pushed add-root-ca-cert-for-telemetry-configuration from 5e055c5b7b to 8a9a1c1841 2024-09-12 10:51:18 +00:00 Compare
AlekseySVTN changed title from WIP #484 Add root ca cert for telemetry configuration to #484 Add root ca cert for telemetry configuration 2024-09-12 11:01:15 +00:00
AlekseySVTN requested review from alexvanin 2024-09-12 11:01:25 +00:00
AlekseySVTN requested review from r.loginov 2024-09-12 11:01:31 +00:00
AlekseySVTN force-pushed add-root-ca-cert-for-telemetry-configuration from 8a9a1c1841 to 3bd01c92d6 2024-09-17 07:05:07 +00:00 Compare
AlekseySVTN force-pushed add-root-ca-cert-for-telemetry-configuration from 3bd01c92d6 to 501dd7dc99 2024-09-17 08:05:52 +00:00 Compare
r.loginov approved these changes 2024-09-17 08:13:21 +00:00
alexvanin approved these changes 2024-09-18 06:34:28 +00:00
AlekseySVTN self-assigned this 2024-09-19 09:08:23 +00:00
alexvanin merged commit 34c1426b9f into master 2024-09-19 11:07:13 +00:00
alexvanin deleted branch add-root-ca-cert-for-telemetry-configuration 2024-09-19 11:07:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
r.loginov
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
AlekseySVTN
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#485
No description provided.
Delete branch "AlekseySVTN/frostfs-s3-gw:add-root-ca-cert-for-telemetry-configuration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?