TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 6 Projects Releases 18 Packages Activity Actions

[#450] Fix aws-chunked header workflow #489

Merged
alexvanin merged 1 commit from pogpp/frostfs-s3-gw:bugfix/450_put_get_payload_range into master 2024-10-26 11:30:29 +00:00
Conversation 0 Commits 1 Files changed 1 +15 -3
pogpp commented 2024-09-11 10:06:50 +00:00
Member
Copy link

Signed-off-by: Pavel Pogodaev p.pogodaev@yadro.com

Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>
pogpp added 1 commit 2024-09-11 10:06:51 +00:00
[#450] Fix aws-chunked header workflow
Some checks failed
/ DCO (pull_request) Successful in 27s
Details
/ Vulncheck (pull_request) Successful in 43s
Details
/ Builds (pull_request) Successful in 1m26s
Details
/ Lint (pull_request) Successful in 2m49s
Details
/ Tests (pull_request) Failing after 1m44s
Details
8a7be9d05f 
Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>
pogpp requested review from alexvanin 2024-09-11 10:07:13 +00:00
pogpp requested review from mbiryukova 2024-09-11 10:07:13 +00:00
pogpp requested review from r.loginov 2024-09-11 10:07:14 +00:00
pogpp force-pushed bugfix/450_put_get_payload_range from 8a7be9d05f to 0c4a9bdf03 2024-09-11 10:07:33 +00:00 Compare
pogpp force-pushed bugfix/450_put_get_payload_range from 0c4a9bdf03 to 8f6ef17687 2024-09-11 12:13:53 +00:00 Compare
pogpp changed title from WIP: [#450] Fix aws-chunked header workflow to [#450] Fix aws-chunked header workflow 2024-09-11 12:14:03 +00:00
pogpp force-pushed bugfix/450_put_get_payload_range from 8f6ef17687 to fc274b9ac0 2024-09-11 12:14:16 +00:00 Compare
pogpp added 1 commit 2024-09-11 12:39:57 +00:00
[#450] Fix aws-chunked header workflow
Some checks failed
/ DCO (pull_request) Successful in 29s
Details
/ Vulncheck (pull_request) Successful in 45s
Details
/ Builds (pull_request) Successful in 1m9s
Details
/ Lint (pull_request) Successful in 2m28s
Details
/ Tests (pull_request) Failing after 1m13s
Details
eb03c729d3 
Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>
pogpp force-pushed bugfix/450_put_get_payload_range from eb03c729d3 to 58089e7759 2024-09-11 12:44:55 +00:00 Compare
pogpp force-pushed bugfix/450_put_get_payload_range from 58089e7759 to 805c5f977a 2024-09-11 13:42:55 +00:00 Compare
alexvanin requested changes 2024-09-11 15:00:37 +00:00
Dismissed
alexvanin left a comment
Owner
Copy link

You have two commits with the same header.

You have two commits with the same header.
api/handler/util.go Outdated
@ -108,1 +108,4 @@
func (h *handler) getPutPayloadSize(r *http.Request) uint64 {
decodeContentSize := r.Header.Get(api.AmzDecodedContentLength)
decodedSize, _ := strconv.Atoi(decodeContentSize)
alexvanin commented 2024-09-11 14:59:09 +00:00
Owner
Copy link

We do not ignore errors. At least use

if err != nil {
    decodeSize = 0
}
We do not ignore errors. At least use ```go if err != nil { decodeSize = 0 }
👍 1
alexvanin marked this conversation as resolved
pogpp force-pushed bugfix/450_put_get_payload_range from 805c5f977a to edb28ed3be 2024-09-11 18:54:27 +00:00 Compare
pogpp force-pushed bugfix/450_put_get_payload_range from edb28ed3be to 48ad6191e3 2024-09-11 19:53:26 +00:00 Compare
pogpp requested review from alexvanin 2024-09-12 11:30:35 +00:00
alexvanin force-pushed bugfix/450_put_get_payload_range from 48ad6191e3 to 42e72889a5 2024-09-13 09:08:27 +00:00 Compare
alexvanin approved these changes 2024-09-13 09:24:06 +00:00
alexvanin merged commit 42e72889a5 into master 2024-09-13 09:38:31 +00:00
alexvanin deleted branch bugfix/450_put_get_payload_range 2024-09-13 09:38:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
mbiryukova
r.loginov
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#489
No description provided.
Delete branch "pogpp/frostfs-s3-gw:bugfix/450_put_get_payload_range"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?