[#486] Fix PUT object with negative Content-Length #490

mbiryukova · 2024-09-12T15:53:06Z

mbiryukova commented

2024-09-12 15:53:06 +00:00

Closes #486

mbiryukova self-assigned this 2024-09-12 15:53:06 +00:00

mbiryukova added 2 commits 2024-09-12 15:53:07 +00:00

[#486 ] Fix PUT encrypted object 07d161eec8

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>

[#486 ] Fix PUT object with negative Content-Length

/ DCO (pull_request) Successful in 48s

Details

/ Vulncheck (pull_request) Successful in 1m13s

Details

/ Builds (pull_request) Successful in 1m27s

Details

/ Lint (pull_request) Successful in 2m25s

Details

/ Tests (pull_request) Successful in 1m27s

Details

e8804e2df1

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>

mbiryukova requested review from storage-services-committers 2024-09-12 15:55:45 +00:00

mbiryukova requested review from storage-services-developers 2024-09-12 15:55:45 +00:00

mbiryukova force-pushed bugfix/negative_content_length from e8804e2df1 to 72c680dd5e

2024-09-13 09:54:19 +00:00

Compare

alexvanin reviewed 2024-09-13 10:36:16 +00:00

api/layer/object.go

					
				@ -266,3 +269,4 @@

						CreationTime: TimeNow(ctx),

						CopiesNumber: p.CopiesNumbers,

					}

					if p.Size != nil {

alexvanin commented

2024-09-13 10:36:16 +00:00

What you think about keeping p.Size as an int, not a pointer, and using p.Size > 0 instead of p.Size != nil?
Isn't it the same but safer due to lack of pointers?

What you think about keeping `p.Size` as an int, not a pointer, and using `p.Size > 0` instead of `p.Size != nil`? Isn't it the same but safer due to lack of pointers?

mbiryukova commented

2024-09-13 15:44:39 +00:00

There may be a case (theoretically) when we put empty multipart object and should save 0 as a size

👍 1

alexvanin marked this conversation as resolved

alexvanin approved these changes 2024-09-16 08:45:39 +00:00

alexvanin merged commit f187141ae5 into master

2024-09-16 08:45:47 +00:00

alexvanin deleted branch bugfix/negative_content_length

2024-09-16 08:45:50 +00:00

~~ognev referenced this pull request 2024-09-16 10:05:28 +00:00~~

[#492] Add panic catchers to fuzzing tests #492