TrueCloudLab/frostfs-s3-gw
17
3
Fork 20
Code Issues 29 Pull requests 9 Projects Releases 33 Packages 1 Activity Actions

[#434] Remove container on failed bucket creation #497

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:feature/434-delete_container_if_something_goes_wrong into master 2024-09-25 07:15:25 +00:00
Conversation 0 Commits 1 Files changed 4 +66 -2
dkirillov commented 2024-09-24 11:46:36 +00:00
Member
Copy link

close #434

close #434
dkirillov self-assigned this 2024-09-24 11:46:36 +00:00
dkirillov added 1 commit 2024-09-24 11:46:37 +00:00
[#434] Remove container on failed bucket creation
All checks were successful
/ DCO (pull_request) Successful in 56s
Details
/ Builds (pull_request) Successful in 1m32s
Details
/ Vulncheck (pull_request) Successful in 1m27s
Details
/ Lint (pull_request) Successful in 2m35s
Details
/ Tests (pull_request) Successful in 1m32s
Details
512e82b8f9 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
requested reviews from storage-services-developers, storage-services-committers 2024-09-24 11:50:06 +00:00
pogpp approved these changes 2024-09-24 11:52:08 +00:00
alexvanin reviewed 2024-09-24 15:10:09 +00:00
api/handler/put.go
@ -818,0 +833,4 @@
chainIDs[i] = c.ID
}
if err := h.ape.DeleteBucketPolicy(reqInfo.Namespace, bktInfo.CID, chainIDs); err != nil {
alexvanin commented 2024-09-24 15:10:09 +00:00
Owner
Copy link

What returns DeleteBucketPolicy if no policy was set during bucket creation process? Does it return error?

What returns `DeleteBucketPolicy` if no policy was set during bucket creation process? Does it return error?
dkirillov commented 2024-09-24 15:13:24 +00:00
Author
Member
Copy link

No error

Lines 176 to 178 in TrueCloudLab/frostfs-contract@3e221b9
if !exists {
return
}

No error https://git.frostfs.info/TrueCloudLab/frostfs-contract/src/commit/3e221b973a3cfe387113990bab56b33f78bc0c18/policy/policy_contract.go#L176-L178
alexvanin approved these changes 2024-09-24 15:10:11 +00:00
r.loginov approved these changes 2024-09-25 02:05:35 +00:00
alexvanin merged commit 738ce14f50 into master 2024-09-25 07:15:25 +00:00
alexvanin deleted branch feature/434-delete_container_if_something_goes_wrong 2024-09-25 07:15:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pogpp
alexvanin
r.loginov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#497
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:feature/434-delete_container_if_something_goes_wrong"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?